You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/01/20 14:05:26 UTC
Review Request 55765: llow user to add custom property for log4j
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55765/
-----------------------------------------------------------
Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.
Bugs: AMBARI-19651
https://issues.apache.org/jira/browse/AMBARI-19651
Repository: ambari
Description
-------
Existing rolling properties like MaxFileSize and MaxBackupIndex for various services have been parameterized for ease of use by end user.
These properties have been added for those services which did not originally have it.
During Ambari Upgrade, user will not be able to see these changes. One way is to document how the user can manually make use of this feature by adding a custom-log4j property as well as change the template with the same variable name as used in the backend python file. This jira is to make UI changes in order to allow user to add custom-log4j properties if they want to after an ambari upgrade.
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml 5a97804
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-log4j.xml 05c8f0a
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml 2662b51
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml 2177705
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 37b339e
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-exec-log4j.xml d90a679
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml 3473b8c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 4ec22770
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml f6045cd
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-log4j.xml 613d75f
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ldap-log4j.xml e078d9d
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml ff1e388
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml 123d570
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml fdffcdf
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml 141c8c9
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 4cbc34e
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 3a63f38
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 92d6c38
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml 45bf289
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1cb17f0
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml c3de7cd
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml 31f0ff3
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml 34e97d4
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 03e8dae
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml aac3216
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml 25315b4
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 4790f0f
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml ec93b63
Diff: https://reviews.apache.org/r/55765/diff/
Testing
-------
Manually tested.
Thanks,
Andrii Tkach
Re: Review Request 55765: llow user to add custom property for log4j
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55765/
-----------------------------------------------------------
(Updated Jan. 23, 2017, 10:36 a.m.)
Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.
Bugs: AMBARI-19651
https://issues.apache.org/jira/browse/AMBARI-19651
Repository: ambari
Description
-------
Existing rolling properties like MaxFileSize and MaxBackupIndex for various services have been parameterized for ease of use by end user.
These properties have been added for those services which did not originally have it.
During Ambari Upgrade, user will not be able to see these changes. One way is to document how the user can manually make use of this feature by adding a custom-log4j property as well as change the template with the same variable name as used in the backend python file. This jira is to make UI changes in order to allow user to add custom-log4j properties if they want to after an ambari upgrade.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml 5a97804
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-log4j.xml 05c8f0a
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml 2662b51
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml 2177705
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 3f73c19
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 37b339e
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-exec-log4j.xml d90a679
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml 3473b8c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 4ec22770
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml f6045cd
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-log4j.xml 613d75f
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ldap-log4j.xml e078d9d
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml ff1e388
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml 123d570
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml fdffcdf
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml 141c8c9
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 4cbc34e
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 3a63f38
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 92d6c38
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml 45bf289
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1cb17f0
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml c3de7cd
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml 31f0ff3
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml 1d828ee
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 151ce3b
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml d052621
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml 34e97d4
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 03e8dae
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml aac3216
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml 25315b4
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 4790f0f
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml ec93b63
Diff: https://reviews.apache.org/r/55765/diff/
Testing
-------
Manually tested.
Thanks,
Andrii Tkach
Re: Review Request 55765: llow user to add custom property for log4j
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55765/#review162457
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml (line 22)
<https://reviews.apache.org/r/55765/#comment233792>
Please also change HDFS 3.0.0.3.0 and YARN 3.0.0.3.0 in common-services.
- Alejandro Fernandez
On Jan. 20, 2017, 2:05 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55765/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:05 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.
>
>
> Bugs: AMBARI-19651
> https://issues.apache.org/jira/browse/AMBARI-19651
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing rolling properties like MaxFileSize and MaxBackupIndex for various services have been parameterized for ease of use by end user.
> These properties have been added for those services which did not originally have it.
> During Ambari Upgrade, user will not be able to see these changes. One way is to document how the user can manually make use of this feature by adding a custom-log4j property as well as change the template with the same variable name as used in the backend python file. This jira is to make UI changes in order to allow user to add custom-log4j properties if they want to after an ambari upgrade.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml 5a97804
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-log4j.xml 05c8f0a
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml 2662b51
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml 2177705
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 37b339e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-exec-log4j.xml d90a679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml 3473b8c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 4ec22770
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml f6045cd
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-log4j.xml 613d75f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ldap-log4j.xml e078d9d
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml ff1e388
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml 123d570
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml fdffcdf
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml 141c8c9
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 4cbc34e
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 3a63f38
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 92d6c38
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml 45bf289
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1cb17f0
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml c3de7cd
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml 31f0ff3
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml 34e97d4
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 03e8dae
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml aac3216
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml 25315b4
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 4790f0f
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml ec93b63
>
> Diff: https://reviews.apache.org/r/55765/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Andrii Tkach
>
>