You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/03 22:06:24 UTC
[GitHub] [druid] gianm opened a new pull request #10351: StringFirstAggregatorFactory: Fix incorrect "combine" method.
gianm opened a new pull request #10351:
URL: https://github.com/apache/druid/pull/10351
There was a test, but it was wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10351: StringFirstAggregatorFactory: Fix incorrect "combine" method.
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10351:
URL: https://github.com/apache/druid/pull/10351#discussion_r483286571
##########
File path: processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstAggregationTest.java
##########
@@ -38,7 +39,7 @@
import java.nio.ByteBuffer;
-public class StringFirstAggregationTest
+public class StringFirstAggregationTest extends NullHandlingTest
Review comment:
Shouldn't this extend `InitializedNullHandlingTest` ? I think `NullHandlingTest` is an actual test... I always get confused between these 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a change in pull request #10351: StringFirstAggregatorFactory: Fix incorrect "combine" method.
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #10351:
URL: https://github.com/apache/druid/pull/10351#discussion_r483305529
##########
File path: processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstAggregationTest.java
##########
@@ -38,7 +39,7 @@
import java.nio.ByteBuffer;
-public class StringFirstAggregationTest
+public class StringFirstAggregationTest extends NullHandlingTest
Review comment:
You're right. I fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] fjy merged pull request #10351: StringFirstAggregatorFactory: Fix incorrect "combine" method.
Posted by GitBox <gi...@apache.org>.
fjy merged pull request #10351:
URL: https://github.com/apache/druid/pull/10351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org