You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 12:08:44 UTC

[GitHub] [airflow] ashb opened a new pull request #16585: Fix pylint error in tests/

ashb opened a new pull request #16585:
URL: https://github.com/apache/airflow/pull/16585


   I'm not sure _why_ this changed/started failing, as we haven't touched this part of the file recently.
   
   Maybe we upgraded pylint recently?
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #16585: Fix pylint error in tests/

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16585:
URL: https://github.com/apache/airflow/pull/16585#issuecomment-865928629


   One thing I did notice that https://github.com/apache/airflow/pull/16553 only took 4 seconds for the in https://github.com/apache/airflow/runs/2875380969?check_suite_focus=true
   
   ```
   Mon, 21 Jun 2021 13:08:50 GMT Run pylint for main code.................................................Passed
   Mon, 21 Jun 2021 13:11:09 GMT Run pylint for tests.....................................................Passed
   Mon, 21 Jun 2021 13:11:15 GMT Run pylint for helm chart tests..........................................Passed
   ```
   
   4 seconds seems too quite -- running pylint on tests/ locally takes much longer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #16585: Fix pylint error in tests/

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #16585:
URL: https://github.com/apache/airflow/pull/16585


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org