[GitHub] [sedona] jbampton commented on a diff in pull request #662: [SEDONA-142] Add ST_Collect to Flink Catalog

["jbampton (via GitHub)" <gi...@apache.org>]

jbampton commented on code in PR #662:
URL: https://github.com/apache/sedona/pull/662#discussion_r1103674823


##########
flink/src/main/java/org/apache/sedona/flink/SedonaFlinkRegistrator.java:
##########
@@ -36,9 +41,24 @@ public static void registerFunc(StreamTableEnvironment tblEnv) {
         );
     }
 
+    /**
+     * This is needed because for Resolving the RAW Geometry DataType in ST_Collect (MapView in Accumulator)
+     * the serializer needs to be known. To get the registered Serializer the ExecutionEnvironment is needed and
+     * to add the UDF the TableEnvironment ist needed.

Review Comment:
   ```suggestion
        * to add the UDF the TableEnvironment is needed.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org