You are viewing a plain text version of this content. The canonical link for it is here.

Posted to ddlutils-dev@db.apache.org by "Tom Palmer (JIRA)" <ji...@apache.org> on 2010/04/25 19:45:50 UTC

[jira] Updated: (DDLUTILS-255) Test tearDown call of assertAndEnsureClearDatabase masks the real test failure

     [ https://issues.apache.org/jira/browse/DDLUTILS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Palmer updated DDLUTILS-255:
--------------------------------

    Attachment: tearDownMasksRealError.patch

The attached patch overrides the JUnit runBare() method to set a _failed field if the test fails. If this field is set then assertAndEnsureClearDatabase() will not call fail() if the database is unclean.

> Test tearDown call of assertAndEnsureClearDatabase masks the real test failure
> ------------------------------------------------------------------------------
>
>                 Key: DDLUTILS-255
>                 URL: https://issues.apache.org/jira/browse/DDLUTILS-255
>             Project: DdlUtils
>          Issue Type: Bug
>          Components: Core (No specific database)
>    Affects Versions: 1.1
>            Reporter: Tom Palmer
>            Assignee: Thomas Dudziak
>            Priority: Minor
>         Attachments: tearDownMasksRealError.patch
>
>
> Currently TestAgainstLiveDatabaseBase.tearDown() will call assertAndEnsureClearDatabase() even when there is a test failure. Unfortunately this masks the real test failure as often or not the test has created additional data that assertAndEnsureClearDatabase() will throw an AssertionFailedError on. This causes the test failure AssertionFailedError to get replaced by the tearDown() instance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.