You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/18 16:50:48 UTC
[GitHub] [spark] dtenedor opened a new pull request, #37572: [SPARK-40000][SQL] Revert PR 37430 (Update INSERTs without user-specified fields to not automatically add default values)
dtenedor opened a new pull request, #37572:
URL: https://github.com/apache/spark/pull/37572
### What changes were proposed in this pull request?
Revert PR 37430 (Update INSERTs without user-specified fields to not automatically add default values).
This is a clean revert, undoing the original changes from that PR exactly.
### Why are the changes needed?
Upon further review, we find that the ability to switch between the new configuration and the old one is not needed and adds complexity.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test coverage.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37572: [SPARK-40000][SQL] Revert PR 37430 in commit 13c1b59 (Update INSERTs without user-specified fields to not automatically add default values)
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219786419
> @dtenedor . We are reverting commits not PRs. :)
@dongjoon-hyun My bad. This is my first time reverting a previous change in Apache Spark. Updated the PR title and description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
URL: https://github.com/apache/spark/pull/37572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37572: [SPARK-40000][SQL] Revert PR 37430 in commit 13c1b59 (Update INSERTs without user-specified fields to not automatically add default values)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219790699
Let me change the PR title for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37572: [SPARK-40000][SQL] Revert PR 37430 in commit 13c1b59 (Update INSERTs without user-specified fields to not automatically add default values)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219788659
Then, is this a full and complete revert of SPARK-40000?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37572: [SPARK-40000][SQL] Revert PR 37430 (Update INSERTs without user-specified fields to not automatically add default values)
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219716166
Hi @gengliangwang here is the revert of https://github.com/apache/spark/pull/37430.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219802288
> It seems that the numbers of addition and deletion are different from the real reverting commit because this PR has 176 additions and 192 deletion.
@dongjoon-hyun that's a good point, I made an update to make the additions/deletion counts match exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219803249
<img width="1073" alt="image" src="https://user-images.githubusercontent.com/99207096/185467739-838ebac7-ec03-477f-8d35-0611695d47f7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219795640
> Then, is this a full and complete revert of [SPARK-40000](https://issues.apache.org/jira/browse/SPARK-40000)?
Yes, that is the idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #37572: Revert "[SPARK-40000][SQL] Update INSERTs without user-specified fields to not automatically add default values"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #37572:
URL: https://github.com/apache/spark/pull/37572#issuecomment-1219990473
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org