You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mesos.apache.org by bm...@apache.org on 2013/04/20 02:04:56 UTC

svn commit: r1470091 - /incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp

Author: bmahler
Date: Sat Apr 20 00:04:56 2013
New Revision: 1470091

URL: http://svn.apache.org/r1470091
Log:
Removed the loop in Process.settle test, in favor of external looping.

From: Ben Mahler <be...@gmail.com>
Review: https://reviews.apache.org/r/10666

Modified:
    incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp

Modified: incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp
URL: http://svn.apache.org/viewvc/incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp?rev=1470091&r1=1470090&r2=1470091&view=diff
==============================================================================
--- incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp (original)
+++ incubator/mesos/trunk/third_party/libprocess/src/tests/process_tests.cpp Sat Apr 20 00:04:56 2013
@@ -920,17 +920,14 @@ TEST(Process, settle)
 {
   ASSERT_TRUE(GTEST_IS_THREADSAFE);
 
-  // Try 100 times to hit a race.
-  for (int i = 0; i < 100; ++i) {
-    Clock::pause();
-    SettleProcess process;
-    spawn(process);
-    Clock::settle();
-    ASSERT_TRUE(process.calledDispatch);
-    terminate(process);
-    wait(process);
-    Clock::resume();
-  }
+  Clock::pause();
+  SettleProcess process;
+  spawn(process);
+  Clock::settle();
+  ASSERT_TRUE(process.calledDispatch);
+  terminate(process);
+  wait(process);
+  Clock::resume();
 }