You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/12/09 08:52:08 UTC
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/523
Add/pr teamplate
### What is this PR for?
This PR has for goal to set guidelines regarding the **Pull Request** format in order to simplify the reviewer job.
It updates the project guidelines to include the template, and provides an easy click to fill Pull Request tool.
### What type of PR is it?
Documentation
### Todos
* [x] - Include PR Template in the Project Guidelines
* [x] - Small modifications to the project guidelines
* [x] - Add short bookmarklet to the project guidelines
### Is there a relevant Jira issue?
No
### How should this be tested?
* You can check this PR's Markdown files for the documentation
* You can try the bookmarklet by creating a new bookmarked page and copy/pasting the code as its content, then click on it while creating a PR.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? **No**
* Is there breaking changes for older versions? **No**
* Does this needs documentation? **No, it is documentation**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin add/PRTeamplate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit 607255137846f124b040b8fb91433135c174f42e
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T06:30:05Z
Add issue tracker to README
commit ebab2b3a7245a6dc424da957547a42d38e65081b
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T06:57:13Z
Add the PR template to documentation
commit 40ca5d1f61bea415a9b4d3f2642e60b15e5577f8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T06:58:40Z
Fix Source Control Workflow Link
commit 624205917e62343386cfdff3b044b8f02d986d9c
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T07:08:25Z
Add link to WebApplication contribution Guidelines
commit 3e087472251c93c659799c86eba37c8117ade42c
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T07:19:19Z
Modify Zeppelin-web contribution guidelines
commit de895817314b4f729ae43f76e5077adf15879035
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-12-09T07:36:00Z
Fix bookmarklet
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163167311
@corneadoug similar to build status this badge is useful for checking the pr status
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163163806
@corneadoug can you also add PR status in readme ?
`[](http://issuestats.com/github/apache/incubator-zeppelin)`
should look like this in the output
[](http://issuestats.com/github/apache/incubator-zeppelin)
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163147825
1. I don't have a lot of Open Source projects example that I can post right now, but it is quite usual for projects to have their own Issue Template or PR Template. I think it's even more important in an open source project since it gets contribution from a lot of people with different backgrounds.
A few examples that focus mainly on issue templates:
* https://github.com/docker/docker/blob/master/CONTRIBUTING.md
* https://github.com/atom/atom/blob/master/CONTRIBUTING.md
* https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md
2. We documented the Review process and what terminology we use.
But yes, we could probably extend it to a _Tested, LGTM_ when it was tested and not just reviewed.
I wouldn't go as far as making a template for that. As long as the wording we use is defined and documented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by elbamos <gi...@git.apache.org>.
Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163145070
This is a really good template.
Two questions:
1. Do other open source projects find this level of formality necessary? I'm not saying its a bad idea. I just think whenever we have an issue, the first place we look should be to the experience of other projects.
2. Does it make sense to have a template for use *by the reviewer*? I've seen a lot of "looks good to me" written so quickly after a PR is made, there's no way the reviewer could have compiled it, let alone tested it. (I don't think this actually is an issue on other projects.) So I'm wondering if it would be a good idea to ask that reviews give some indication of the nature of the review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163164018
:+1: for bookmarklet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163464015
Then, Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163165199
@r-kamath what would be the used of that badge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add/pr teamplate
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163384653
Looks good to me. Tested bookmarklet works really well.
FYI, According to issuestat.com that @r-kamath has mentions,
Time distribution of pr close in apache zeppelin is look like
while other well known projects like Apache spark
and Apache flink
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---