You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2012/10/02 00:01:09 UTC

[jira] [Created] (ZOOKEEPER-1553) Findbugs configuration is missing some dependencies

Sean Busbey created ZOOKEEPER-1553:
--------------------------------------

             Summary: Findbugs configuration is missing some dependencies
                 Key: ZOOKEEPER-1553
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1553
             Project: ZooKeeper
          Issue Type: Bug
          Components: build
    Affects Versions: 3.5.0
            Reporter: Sean Busbey
            Priority: Minor


While updating the findbugs configuration to account for a change in log4j versions I noticed findbugs complaining about access to the netty and slf4j classes.

Steps to reproduce:

# install findbugs to $FINDBUGS_HOME
# run ant -Dfindbugs.home="$FINDBUGS_HOME" findbugs



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1553) Findbugs configuration is missing some dependencies

Posted by "Sean Busbey (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467746#comment-13467746 ] 

Sean Busbey commented on ZOOKEEPER-1553:
----------------------------------------

No new tests because the patch is a configuration change to findbugs. You can manually test by running step #2 of the reproduce after the patch and findbugs will no longer complain about unknown classes.
                
> Findbugs configuration is missing some dependencies
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-1553
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1553
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.5.0
>            Reporter: Sean Busbey
>            Priority: Minor
>         Attachments: ZOOKEEPER-1553.patch
>
>
> While updating the findbugs configuration to account for a change in log4j versions I noticed findbugs complaining about access to the netty and slf4j classes.
> Steps to reproduce:
> # install findbugs to $FINDBUGS_HOME
> # run ant -Dfindbugs.home="$FINDBUGS_HOME" findbugs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1553) Findbugs configuration is missing some dependencies

Posted by "Sean Busbey (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey updated ZOOKEEPER-1553:
-----------------------------------

    Attachment: ZOOKEEPER-1553.patch

Changes auxClasspath for findbugs to all the jars in the ivy lib directory.

Fixes the immediate issue of not including dependencies other than log4j and also makes sure we'll include future dependency changes/additions.
                
> Findbugs configuration is missing some dependencies
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-1553
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1553
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.5.0
>            Reporter: Sean Busbey
>            Priority: Minor
>         Attachments: ZOOKEEPER-1553.patch
>
>
> While updating the findbugs configuration to account for a change in log4j versions I noticed findbugs complaining about access to the netty and slf4j classes.
> Steps to reproduce:
> # install findbugs to $FINDBUGS_HOME
> # run ant -Dfindbugs.home="$FINDBUGS_HOME" findbugs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1553) Findbugs configuration is missing some dependencies

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467288#comment-13467288 ] 

Hadoop QA commented on ZOOKEEPER-1553:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547290/ZOOKEEPER-1553.patch
  against trunk revision 1391526.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1202//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1202//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1202//console

This message is automatically generated.
                
> Findbugs configuration is missing some dependencies
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-1553
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1553
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.5.0
>            Reporter: Sean Busbey
>            Priority: Minor
>         Attachments: ZOOKEEPER-1553.patch
>
>
> While updating the findbugs configuration to account for a change in log4j versions I noticed findbugs complaining about access to the netty and slf4j classes.
> Steps to reproduce:
> # install findbugs to $FINDBUGS_HOME
> # run ant -Dfindbugs.home="$FINDBUGS_HOME" findbugs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira