[GitHub] alopresto commented on a change in pull request #153: NIFIREG-220 New test certs

[GitBox <gi...@apache.org>]

alopresto commented on a change in pull request #153: NIFIREG-220 New test certs
URL: https://github.com/apache/nifi-registry/pull/153#discussion_r242665058
 
 

 ##########
 File path: nifi-registry-core/nifi-registry-web-api/src/test/resources/application-ITSecureFile.properties
 ##########
 @@ -28,9 +28,9 @@ nifi.registry.client.properties.file: src/test/resources/conf/secure-file/nifi-r
 
 # Embedded Server SSL Context Config
 server.ssl.client-auth: need
-server.ssl.key-store: ./target/test-classes/keys/localhost-ks.jks
-server.ssl.key-store-password: localhostKeystorePassword
-server.ssl.key-password: localhostKeystorePassword
+server.ssl.key-store: ./target/test-classes/keys/registry-ks.jks
 
 Review comment:
   Is there a reason for the inconsistent formatting of these keys? Ideally, I'd prefer if `ssl` was changed to `tls`, but I understand legacy naming. However, the `.` and `-` seem odd. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services