You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2016/03/22 02:27:25 UTC
Review Request 45145: Atlas alert present when WE is enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45145/
-----------------------------------------------------------
Review request for Ambari, John Speidel and Robert Levas.
Bugs: AMBARI-15500
https://issues.apache.org/jira/browse/AMBARI-15500
Repository: ambari
Description
-------
Two alerts are critical: Atlas Metadata Server Process, Metadata Server Web UI.
Atlas alerts are checking wrong port (http not https) when wire encryption is enabled.
In the file "common-services/ATLAS/0.1.0.2.3/package/scripts/params.py" there is code that sets the curl command that is used to connect to the atlas service during the smoke test. It appears that this code has "http" hard coded.
if security_enabled:
smoke_cmd = format('curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
else:
smoke_cmd = format('curl -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py c5059dd
ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/secure.json b48ae97
Diff: https://reviews.apache.org/r/45145/diff/
Testing
-------
Manual test Ambari / Atlas service check.
mvn clean test
all pass
Thanks,
Tom Beerbower
Re: Review Request 45145: Atlas alert present when WE is enabled
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On March 22, 2016, 1:37 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py, line 117
> > <https://reviews.apache.org/r/45145/diff/1/?file=1309684#file1309684line117>
> >
> > Have you seen the `curl_krb_request` stuff. This may come in handy. It helps with managing the credential cache and setting the cache so that it doesn't mess with the user's interactive cache.
> >
> > Take a look, you might want to incorporrate it.
Thanks for the review!
I didn't know about curl_krb_request. I'll look into it and open a separate Jira to make use of it.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45145/#review124789
-----------------------------------------------------------
On March 22, 2016, 1:27 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45145/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 1:27 a.m.)
>
>
> Review request for Ambari, John Speidel and Robert Levas.
>
>
> Bugs: AMBARI-15500
> https://issues.apache.org/jira/browse/AMBARI-15500
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two alerts are critical: Atlas Metadata Server Process, Metadata Server Web UI.
>
> Atlas alerts are checking wrong port (http not https) when wire encryption is enabled.
>
> In the file "common-services/ATLAS/0.1.0.2.3/package/scripts/params.py" there is code that sets the curl command that is used to connect to the atlas service during the smoke test. It appears that this code has "http" hard coded.
>
> if security_enabled:
> smoke_cmd = format('curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
> else:
> smoke_cmd = format('curl -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py c5059dd
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/secure.json b48ae97
>
> Diff: https://reviews.apache.org/r/45145/diff/
>
>
> Testing
> -------
>
> Manual test Ambari / Atlas service check.
>
> mvn clean test
>
> all pass
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 45145: Atlas alert present when WE is enabled
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45145/#review124789
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py (line 117)
<https://reviews.apache.org/r/45145/#comment187449>
Have you seen the `curl_krb_request` stuff. This may come in handy. It helps with managing the credential cache and setting the cache so that it doesn't mess with the user's interactive cache.
Take a look, you might want to incorporrate it.
- Robert Levas
On March 21, 2016, 9:27 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45145/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 9:27 p.m.)
>
>
> Review request for Ambari, John Speidel and Robert Levas.
>
>
> Bugs: AMBARI-15500
> https://issues.apache.org/jira/browse/AMBARI-15500
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two alerts are critical: Atlas Metadata Server Process, Metadata Server Web UI.
>
> Atlas alerts are checking wrong port (http not https) when wire encryption is enabled.
>
> In the file "common-services/ATLAS/0.1.0.2.3/package/scripts/params.py" there is code that sets the curl command that is used to connect to the atlas service during the smoke test. It appears that this code has "http" hard coded.
>
> if security_enabled:
> smoke_cmd = format('curl --negotiate -u : -b ~/cookiejar.txt -c ~/cookiejar.txt -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
> else:
> smoke_cmd = format('curl -s -o /dev/null -w "%{{http_code}}" http://{metadata_host}:{metadata_port}/')
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py c5059dd
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/secure.json b48ae97
>
> Diff: https://reviews.apache.org/r/45145/diff/
>
>
> Testing
> -------
>
> Manual test Ambari / Atlas service check.
>
> mvn clean test
>
> all pass
>
>
> Thanks,
>
> Tom Beerbower
>
>