[jira] [Comment Edited] (HDDS-248) Refactor DatanodeContainerProtocol.proto

["Bharat Viswanadham (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560441#comment-16560441 ] 

Bharat Viswanadham edited comment on HDDS-248 at 7/27/18 10:51 PM:
-------------------------------------------------------------------

Hi [~hanishakoneru]

Thanks for the patch. Overall LGTM. 

+1 after fixing below comment.

One minor comment:

In KeyValueHandler.java: Line235, we can remove this check, as this already checked and we get handler.
{code:java}
if (!createRequest.getContainerType()
 .equals(ContainerType.KeyValueContainer)) {
 return ContainerUtils.malformedRequest(request);
}{code}


was (Author: bharatviswa):
Hi [~hanishakoneru]

Thanks for the patch. Over all LGTM.

One minor comment:

In KeyValueHandler.java: Line235, we can remove this check, as this already checked and we get handler.
{code:java}
if (!createRequest.getContainerType()
 .equals(ContainerType.KeyValueContainer)) {
 return ContainerUtils.malformedRequest(request);
}{code}

> Refactor DatanodeContainerProtocol.proto 
> -----------------------------------------
>
>                 Key: HDDS-248
>                 URL: https://issues.apache.org/jira/browse/HDDS-248
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-248.001.patch, HDDS-248.002.patch, HDDS-248.003.patch
>
>
> This Jira proposes to cleanup the DatanodeContainerProtocol protos and refactor as per the new implementation of StorageIO in HDDS-48. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org