You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by cwestin <gi...@git.apache.org> on 2015/08/04 20:30:41 UTC
[GitHub] drill pull request: DRILL-3598: use a factory to create the root a...
GitHub user cwestin opened a pull request:
https://github.com/apache/drill/pull/104
DRILL-3598: use a factory to create the root allocator.
- made the constructor for TopLevelAllocator package private to enforce this
- other file cleanup in files the factory was added to
Unit tests pass. Precommit suite passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwestin/incubator-drill alloc-factory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit 4d7021582bd31b5fc92c882af1fb467bd8e58ad1
Author: Chris Westin <cw...@yahoo.com>
Date: 2015-08-04T13:26:57Z
DRILL-3598: use a factory to create the root allocator.
- made the constructor for TopLevelAllocator package private to enforce this
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3598: use a factory to create the root a...
Posted by cwestin <gi...@git.apache.org>.
Github user cwestin commented on the pull request:
https://github.com/apache/drill/pull/104#issuecomment-139064541
It looks like you've merged this -- is there any reason not to close the pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3598: use a factory to create the root a...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/104#issuecomment-139066368
Sorry about that, I will be making sure I do this in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3598: use a factory to create the root a...
Posted by cwestin <gi...@git.apache.org>.
Github user cwestin closed the pull request at:
https://github.com/apache/drill/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3598: use a factory to create the root a...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/104#issuecomment-139065032
If we forget to add the "this closes #xxx" to the commit message then the only person who can close a PR is the original author. You should close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---