[jira] [Comment Edited] (HBASE-10164) Allow heapsize of different units to be passed as HBASE_HEAPSIZE

["rajeshbabu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848499#comment-13848499 ] 

rajeshbabu edited comment on HBASE-10164 at 12/15/13 1:27 AM:
--------------------------------------------------------------

lgtm. +1
nit. format at fi.
{code}
+	fi
{code}
can be
{code}
+  fi
{code}


was (Author: rajesh23):
lgtm. +1

> Allow heapsize of different units to be passed as HBASE_HEAPSIZE
> ----------------------------------------------------------------
>
>                 Key: HBASE-10164
>                 URL: https://issues.apache.org/jira/browse/HBASE-10164
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 10164-v1.txt
>
>
> Currently HBASE_HEAPSIZE doesn't expect units.
> {code}
> $ HBASE_HEAPSIZE=5G /usr/lib/hbase/bin/hbase shell
> Invalid maximum heap size: -Xmx5Gm
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> {code}
> It would be more user friendly if different units of heapsize can be passed through HBASE_HEAPSIZE
> If unit ('m' or 'G') is specified, 'm' doesn't need to be appended.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)