[py tests] status on file externals ignored intentionally?

[Neels Janosch Hofmeyr <ne...@elego.de>]

Hi,

I just noticed that in the python tests, status verification on externals
isn't possible, because the function that creates the status tree from the
output conveniently ignores lines on file externals.

A file external line looks like this:

"    X            3        2 jrandom      /A/C/external"

and that X in the fifth column doesn't match the patterns used in

  svntest.wc.State.from_status()

and these lines are ignored.

In effect, externals can't be covered by run_and_verify_status(), for instance.

I'd just like to know whether that is actually intentional. Otherwise I'll
try grokking how to enhance the patterns in State.from_status().

~Neels

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1463475

Re: [py tests] status on file externals ignored intentionally?

[Greg Stein <gs...@gmail.com>]

Not intentional. The wc.StateItem objects needs to be expanded to
handle the file externals.

Cheers,
-g

On Sun, Mar 29, 2009 at 01:31, Neels Janosch Hofmeyr <ne...@elego.de> wrote:
> Hi,
>
> I just noticed that in the python tests, status verification on externals
> isn't possible, because the function that creates the status tree from the
> output conveniently ignores lines on file externals.
>
> A file external line looks like this:
>
> "    X            3        2 jrandom      /A/C/external"
>
> and that X in the fifth column doesn't match the patterns used in
>
>  svntest.wc.State.from_status()
>
> and these lines are ignored.
>
> In effect, externals can't be covered by run_and_verify_status(), for instance.
>
> I'd just like to know whether that is actually intentional. Otherwise I'll
> try grokking how to enhance the patterns in State.from_status().
>
> ~Neels
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1463475

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1465141