You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by sixmen <gi...@git.apache.org> on 2017/01/12 09:10:30 UTC

[GitHub] zeppelin pull request #1893: [ZEPPELIN-451] Save codes and messages as multi...

GitHub user sixmen opened a pull request:

    https://github.com/apache/zeppelin/pull/1893

    [ZEPPELIN-451] Save codes and messages as multi-line

    ### What is this PR for?
    Save Paragraph texts and result msgs as array of strings instead of one long string.
    One long strings are not VCS-friendly.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-451
    
    ### How should this be tested?
    Modify notebooks and check saved note files
    
    ### Screenshots (if appropriate)
    <img width="813" alt="2017-01-12 6 09 23" src="https://cloud.githubusercontent.com/assets/1409279/21883411/569a8c06-d8f2-11e6-996b-757cefab70c9.png">
    <img width="852" alt="2017-01-12 6 09 40" src="https://cloud.githubusercontent.com/assets/1409279/21883416/5a511f90-d8f2-11e6-8a6c-4a45cf78d1cd.png">
    
    
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? Notebooks from new zeppelin can not be imported in old zeppelin.
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sixmen/zeppelin note_multiline_string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1893
    
----
commit 15a6d0e8dc2a224e8117c6ed9aeb9062946a1845
Author: Sangmin Yoon <sa...@croquis.com>
Date:   2016-12-27T01:57:42Z

    rename NotebookImportDeserializer to DateDeserializer

commit 843af4cdd45bc3c822b4dc33726dae60f76b4a99
Author: Sangmin Yoon <sa...@croquis.com>
Date:   2016-12-27T01:58:41Z

    save Paragraph.text as list of strings

commit 56e54f5570923f6037c8f9084dc22954004f5b14
Author: Sangmin Yoon <sa...@croquis.com>
Date:   2016-12-27T01:58:51Z

    save InterpreterResultMessage.data as list of strings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1893: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1893
  
    @sixmen Thanks for the contribution. 
    I tested this branch and it works well.
    
    While this makes incompatible changes (previous version of Zeppelin can't load the notebook), i'd like to ask more people review this PR, will there be any type of side effects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1893: [ZEPPELIN-451] Save codes and messages as multi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1893


---

[GitHub] zeppelin issue #1893: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by soralee <gi...@git.apache.org>.

Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/1893
  
    Thank @sixmen for improving this. It's very good feature!
    
    I think sudden changes, part of importing notebook, will make users uncomfortable. 
    In my opinion, both old version notebook and now version notebook should be nice if it is compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1893: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by sixmen <gi...@git.apache.org>.

Github user sixmen commented on the issue:

    https://github.com/apache/zeppelin/pull/1893
  
    @soralee You mean, it is good if users of old Zeppelin can import new version notebooks?
    
    I think forward compatibility is unnecessary, but if you tell me a solution that you want, I'll try to implement it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---