You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/12/04 10:40:10 UTC

[GitHub] incubator-zeppelin pull request: Add job operation API

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/465#issuecomment-161920760
  
    Notebook Rest API returns,
    
    ```
    CREATED, on createNote
    OK,      on deleteNote
    CREATED, on cloneNote
    ```
    
    Interpreter Rest API returns
    
    ```
    CREATED, on newSetting
    OK,      on updateSetting
    OK,      on removeSetting
    OK,      on restartSetting
    ```
    
    This PR adds 8 more APIs
    
    ```
    ACCEPTED, on runNoteJobs
    ACCEPTED, on stopNoteJobs
    OK,       on getNoteJobStatus
    ACCEPTED, on runParagraph
    ACCEPTED, on stopParagraph
    ACCEPTED, on registerCronJob
    ACCEPTED, on removeCronJob
    OK,       on getCronJob
    ```
    
    I think return Status need to be little bit more consistent.
    For example, removeCronJob returns `ACCEPTED`, but deleteNote returns `OK`.
    
    So, i think changing `ACCEPTED` to `OK` for all new APIs makes api more consistent.
    What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---