You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ga...@apache.org on 2013/09/16 17:35:23 UTC
svn commit: r1523706 - in
/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions:
PDFDictionaryElement.java PDFDictionaryEntryElement.java
PDFDictionaryExtension.java
Author: gadams
Date: Mon Sep 16 15:35:23 2013
New Revision: 1523706
URL: http://svn.apache.org/r1523706
Log:
FOP-2298: Java 5 doesn't support String.isEmpty
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryElement.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryEntryElement.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryExtension.java
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryElement.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryElement.java?rev=1523706&r1=1523705&r2=1523706&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryElement.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryElement.java Mon Sep 16 15:35:23 2013
@@ -66,7 +66,7 @@ public class PDFDictionaryElement extend
String key = attlist.getValue(ATT_KEY);
if (key == null) {
missingPropertyError(ATT_KEY);
- } else if (key.isEmpty()) {
+ } else if (key.length() == 0) {
invalidPropertyValueError(ATT_KEY, key, null);
} else {
extension.setKey(key);
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryEntryElement.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryEntryElement.java?rev=1523706&r1=1523705&r2=1523706&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryEntryElement.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryEntryElement.java Mon Sep 16 15:35:23 2013
@@ -55,7 +55,7 @@ public class PDFDictionaryEntryElement e
String key = attlist.getValue("key");
if (key == null) {
missingPropertyError("key");
- } else if (key.isEmpty()) {
+ } else if (key.length() == 0) {
invalidPropertyValueError("key", key, null);
} else {
extension.setKey(key);
@@ -86,7 +86,7 @@ public class PDFDictionaryEntryElement e
invalidPropertyValueError("<value>", value, null);
}
} else if (extension.getType() == PDFDictionaryEntryType.Name) {
- if (value.isEmpty()) {
+ if (value.length() == 0) {
invalidPropertyValueError("<value>", value, null);
}
} else if (extension.getType() == PDFDictionaryEntryType.Number) {
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryExtension.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryExtension.java?rev=1523706&r1=1523705&r2=1523706&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryExtension.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/extensions/PDFDictionaryExtension.java Mon Sep 16 15:35:23 2013
@@ -82,7 +82,7 @@ public class PDFDictionaryExtension exte
return false;
}
String pageNumbers = getProperty(PROPERTY_PAGE_NUMBERS);
- if ((pageNumbers == null) || pageNumbers.isEmpty()) {
+ if ((pageNumbers == null) || (pageNumbers.length() == 0)) {
return false;
} else if (pageNumbers.equals("*")) {
return true;
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org