[GitHub] [incubator-superset] nytai commented on a change in pull request #10922: feat: update saved query backend routing + add savedquery list

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10922:
URL: https://github.com/apache/incubator-superset/pull/10922#discussion_r489778259



##########
File path: superset-frontend/src/views/CRUD/data/common.ts
##########
@@ -36,8 +36,8 @@ export const commonMenuData = {
     {
       name: 'Saved Queries',
       label: t('Saved Queries'),
-      url: '/sqllab/my_queries/',
-      usesRouter: false,
+      url: '/savedqueryview/list/',
+      usesRouter: true,

Review comment:
       does this still work if the feature flags are not enabled? 

##########
File path: superset/views/sql_lab.py
##########
@@ -75,6 +76,17 @@ class SavedQueryView(
         "changed_on": _("Changed on"),
     }
 
+    @expose("/list/")
+    @has_access
+    def list(self) -> FlaskResponse:
+        if not (
+            app.config["ENABLE_REACT_CRUD_VIEWS"]
+            and feature_flag_manager.is_feature_enabled("SIP_34_DATABASE_UI")

Review comment:
       let's add a new feature flag specific to this one, maybe `SIP_34_SAVED_QUERIES_UI` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org