[GitHub] [apisix] tzssangglass commented on a diff in pull request #7822: feat: Add ability to inject headers to otel traces

[GitBox <gi...@apache.org>]

tzssangglass commented on code in PR #7822:
URL: https://github.com/apache/apisix/pull/7822#discussion_r959447194


##########
apisix/plugins/opentelemetry.lua:
##########
@@ -273,6 +280,25 @@ local function create_tracer_obj(conf)
 end
 
 
+local function inject_attributes(attributes, wanted_attributes, source)
+    for _, key in ipairs(wanted_attributes) do
+        local is_key_a_match = #key >= 2 and string.sub(key, -1, -1) == "*"

Review Comment:
   ```suggestion
           local is_key_a_match = #key >= 2 and key:sub(-1, -1) == "*"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org