You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "John Lindal (JIRA)" <ji...@apache.org> on 2007/10/10 23:50:37 UTC
[jira] Created: (WW-2245) Make it easier to extend
XmlConfigurationProvider
Make it easier to extend XmlConfigurationProvider
-------------------------------------------------
Key: WW-2245
URL: https://issues.apache.org/struts/browse/WW-2245
Project: Struts 2
Issue Type: Improvement
Reporter: John Lindal
The only way that I have found to extend org.apache.struts2.config.StrutsXmlConfigurationProvider to construct a derived class of ActionConfig is to override addAction(). Unfortunately, this requires copying the existing function from XmlConfigurationProvider. It would be nice if addAction() used a protected factory method to construct the ActionConfig object, e.g.,
protected ActionConfig constructActionConfig(actionElement, packageContext, methodName, className, results);
With this factory method, I would not have to copy any code out of XmlConfigurationProvider.
Of course, if I missed something, please let me know :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2245) Make it easier to extend
XmlConfigurationProvider
Posted by "John Lindal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lindal updated WW-2245:
----------------------------
Priority: Minor (was: Major)
> Make it easier to extend XmlConfigurationProvider
> -------------------------------------------------
>
> Key: WW-2245
> URL: https://issues.apache.org/struts/browse/WW-2245
> Project: Struts 2
> Issue Type: Improvement
> Reporter: John Lindal
> Priority: Minor
>
> The only way that I have found to extend org.apache.struts2.config.StrutsXmlConfigurationProvider to construct a derived class of ActionConfig is to override addAction(). Unfortunately, this requires copying the existing function from XmlConfigurationProvider. It would be nice if addAction() used a protected factory method to construct the ActionConfig object, e.g.,
> protected ActionConfig constructActionConfig(actionElement, packageContext, methodName, className, results);
> With this factory method, I would not have to copy any code out of XmlConfigurationProvider.
> Of course, if I missed something, please let me know :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2245) Make it easier to extend
XmlConfigurationProvider
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown resolved WW-2245.
---------------------------
Resolution: Won't Fix
Fix Version/s: (was: 2.1.3)
Assignee: Don Brown
Well, we could certainly extract that bit, but, at least with the current implementation of XmlConfigurationProvider, you wouldn't be saving many lines of code. Besides, subclasses of ActionConfig would actually get lost later in the generation of the RuntimeConfiguration. From our previous discussion, it sounded like you found a way around this, but if not, feel free to reopen.
> Make it easier to extend XmlConfigurationProvider
> -------------------------------------------------
>
> Key: WW-2245
> URL: https://issues.apache.org/struts/browse/WW-2245
> Project: Struts 2
> Issue Type: Improvement
> Components: XML Configuration
> Reporter: John Lindal
> Assignee: Don Brown
> Priority: Minor
>
> The only way that I have found to extend org.apache.struts2.config.StrutsXmlConfigurationProvider to construct a derived class of ActionConfig is to override addAction(). Unfortunately, this requires copying the existing function from XmlConfigurationProvider. It would be nice if addAction() used a protected factory method to construct the ActionConfig object, e.g.,
> protected ActionConfig constructActionConfig(actionElement, packageContext, methodName, className, results);
> With this factory method, I would not have to copy any code out of XmlConfigurationProvider.
> Of course, if I missed something, please let me know :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2245) Make it easier to extend
XmlConfigurationProvider
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2245:
--------------------------
Fix Version/s: (was: 2.1.4)
2.1.3
> Make it easier to extend XmlConfigurationProvider
> -------------------------------------------------
>
> Key: WW-2245
> URL: https://issues.apache.org/struts/browse/WW-2245
> Project: Struts 2
> Issue Type: Improvement
> Components: XML Configuration
> Reporter: John Lindal
> Priority: Minor
> Fix For: 2.1.3
>
>
> The only way that I have found to extend org.apache.struts2.config.StrutsXmlConfigurationProvider to construct a derived class of ActionConfig is to override addAction(). Unfortunately, this requires copying the existing function from XmlConfigurationProvider. It would be nice if addAction() used a protected factory method to construct the ActionConfig object, e.g.,
> protected ActionConfig constructActionConfig(actionElement, packageContext, methodName, className, results);
> With this factory method, I would not have to copy any code out of XmlConfigurationProvider.
> Of course, if I missed something, please let me know :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.