[GitHub] [arrow-rs] yah01 commented on a diff in pull request #4226: Support to read/write parquet for FixedSizeList type

["yah01 (via GitHub)" <gi...@apache.org>]

yah01 commented on code in PR #4226:
URL: https://github.com/apache/arrow-rs/pull/4226#discussion_r1200268851


##########
parquet/src/arrow/array_reader/list_array.rs:
##########
@@ -227,8 +228,13 @@ impl<OffsetSize: OffsetSizeTrait> ArrayReader for ListArrayReader<OffsetSize> {
 
         let list_data = unsafe { data_builder.build_unchecked() };
 
-        let result_array = GenericListArray::<OffsetSize>::from(list_data);
-        Ok(Arc::new(result_array))
+        let result_array: ArrayRef = match *list_data.data_type() {
+            ArrowType::FixedSizeList(_, _) => {
+                Arc::new(FixedSizeListArray::from(list_data))

Review Comment:
   > This is actually significantly more complicated, as the null padding logic is different for fixed size types. I'll have a think about how this could be supported
   
   Thank you @tustvold, I know not much about arrow implementation, please let me know if it's too complex so that I can't handle



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org