You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/08/27 13:50:40 UTC
Review Request 25095: [FALCON-643] Tests with zero-output/input
scenario amended to match test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25095/
-----------------------------------------------------------
Review request for Falcon.
Bugs: 643
https://issues.apache.org/jira/browse/643
Repository: falcon-git
Description
-------
Test cases didn't match their scenarios. NoOutputProcessTest amended, PrismFeedUpdateTest partially complete.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java df63483
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java b6bf6d6
Diff: https://reviews.apache.org/r/25095/diff/
Testing
-------
Tested. PismFeedUpdateTest passes. NoOutputProcessTest fails due to another issue.
Thanks,
Paul Isaychuk
Re: Review Request 25095: [FALCON-643] Tests with zero-output/input
scenario amended to match test case
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25095/#review52053
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Aug. 28, 2014, 4:52 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25095/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 4:52 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: 643
> https://issues.apache.org/jira/browse/643
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases didn't match their scenarios. NoOutputProcessTest amended, PrismFeedUpdateTest partially complete.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java df63483
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java b6bf6d6
>
> Diff: https://reviews.apache.org/r/25095/diff/
>
>
> Testing
> -------
>
> Tested. PismFeedUpdateTest passes. NoOutputProcessTest fails due to another issue.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 25095: [FALCON-643] Tests with zero-output/input
scenario amended to match test case
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25095/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 11:52 a.m.)
Review request for Falcon.
Changes
-------
Javadocs added
Bugs: 643
https://issues.apache.org/jira/browse/643
Repository: falcon-git
Description
-------
Test cases didn't match their scenarios. NoOutputProcessTest amended, PrismFeedUpdateTest partially complete.
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java df63483
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java b6bf6d6
Diff: https://reviews.apache.org/r/25095/diff/
Testing
-------
Tested. PismFeedUpdateTest passes. NoOutputProcessTest fails due to another issue.
Thanks,
Paul Isaychuk
Re: Review Request 25095: [FALCON-643] Tests with zero-output/input
scenario amended to match test case
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25095/#review51699
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
<https://reviews.apache.org/r/25095/#comment90245>
As you are making changes to the test - can you please add javadoc for it ?
- Raghav Gautam
On Aug. 27, 2014, 4:50 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25095/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2014, 4:50 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: 643
> https://issues.apache.org/jira/browse/643
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases didn't match their scenarios. NoOutputProcessTest amended, PrismFeedUpdateTest partially complete.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java df63483
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java b6bf6d6
>
> Diff: https://reviews.apache.org/r/25095/diff/
>
>
> Testing
> -------
>
> Tested. PismFeedUpdateTest passes. NoOutputProcessTest fails due to another issue.
>
>
> Thanks,
>
> Paul Isaychuk
>
>