You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/02/13 06:52:28 UTC
Review Request 30966: SENTRY-629: Improve test cases in
"TestPrivilegesAtTableScope"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30966/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
Improve test cases in "TestPrivilegesAtTableScope"
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 7c861d3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 0c15389
Diff: https://reviews.apache.org/r/30966/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 30966: SENTRY-629: Improve test cases in
"TestPrivilegesAtTableScope"
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30966/#review72345
-----------------------------------------------------------
Ship it!
Ship It!
- Xiaomeng Huang
On 二月 13, 2015, 7:45 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30966/
> -----------------------------------------------------------
>
> (Updated 二月 13, 2015, 7:45 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Improve test cases in "TestPrivilegesAtTableScope"
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 7c861d3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 0c15389
>
> Diff: https://reviews.apache.org/r/30966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 30966: SENTRY-629: Improve test cases in
"TestPrivilegesAtTableScope"
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30966/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 7:45 a.m.)
Review request for sentry.
Repository: sentry
Description
-------
Improve test cases in "TestPrivilegesAtTableScope"
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 7c861d3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 0c15389
Diff: https://reviews.apache.org/r/30966/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 30966: SENTRY-629: Improve test cases in
"TestPrivilegesAtTableScope"
Posted by Colin Ma <ju...@intel.com>.
> On Feb. 13, 2015, 7:25 a.m., Xiaomeng Huang wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java, line 36
> > <https://reviews.apache.org/r/30966/diff/1/?file=862915#file862915line36>
> >
> > could you put setupAdmin into prepareDBDataForTest?
thanks for the comments, done.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30966/#review72338
-----------------------------------------------------------
On Feb. 13, 2015, 7:45 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30966/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 7:45 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Improve test cases in "TestPrivilegesAtTableScope"
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 7c861d3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 0c15389
>
> Diff: https://reviews.apache.org/r/30966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 30966: SENTRY-629: Improve test cases in
"TestPrivilegesAtTableScope"
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30966/#review72338
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java
<https://reviews.apache.org/r/30966/#comment118429>
why do this change?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java
<https://reviews.apache.org/r/30966/#comment118430>
could you put setupAdmin into prepareDBDataForTest?
- Xiaomeng Huang
On 二月 13, 2015, 5:52 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30966/
> -----------------------------------------------------------
>
> (Updated 二月 13, 2015, 5:52 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Improve test cases in "TestPrivilegesAtTableScope"
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 7c861d3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 0c15389
>
> Diff: https://reviews.apache.org/r/30966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>