You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/09 16:10:57 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #12276: MINOR: Remove ReplicaManagerTest.initializeLogAndTopicId

ijuma commented on code in PR #12276:
URL: https://github.com/apache/kafka/pull/12276#discussion_r893705374


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -1953,6 +1935,7 @@ class ReplicaManagerTest {
     val mockLogMgr: LogManager = mock(classOf[LogManager])
     when(mockLogMgr.liveLogDirs).thenReturn(config.logDirs.map(new File(_).getAbsoluteFile))
     when(mockLogMgr.getOrCreateLog(ArgumentMatchers.eq(topicPartitionObj), ArgumentMatchers.eq(false), ArgumentMatchers.eq(false), any())).thenReturn(mockLog)
+//    when(mockLogMgr.getLog(topicPartitionObj, isFuture = false)).thenReturn(Some(mockMergedLog))

Review Comment:
   No :) The test doesn't pass unless this is commented out. Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org