You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/31 19:02:22 UTC
[GitHub] [incubator-yunikorn-core] yangwwei opened a new pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action
yangwwei opened a new pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244#discussion_r567513857
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,34 @@
+name: Pre-commit checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Set up Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: 1.15
+
+ - name: Checkout source code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
Review comment:
We do not need all logs etc in YUNIKORN-285 we changed the fetch depth to 2 to make it all work and it safes a lot of data being pulled out.
We should have `fetch-depth: 2`, will fix on commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244#discussion_r567513896
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,34 @@
+name: Pre-commit checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Set up Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: 1.15
+
+ - name: Checkout source code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+
+ - name: Check license
+ run: make license-check
+
+ - name: Go lint
+ run: |
+ curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
+ make lint
+ - name: unit test
+ run: make test
+
+ - name: Code coverage
+ uses: codecov/codecov-action@v1
Review comment:
missing eol, will fix on commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #244: [YUNIKORN-530] scheduler-core repo: migrate to github action
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #244:
URL: https://github.com/apache/incubator-yunikorn-core/pull/244#issuecomment-770454362
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=h1) Report
> Merging [#244](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=desc) (2be7277) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc) (5a1c19e) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 60 60
Lines 5220 5220
=======================================
Hits 3313 3313
Misses 1747 1747
Partials 160 160
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=footer). Last update [5a1c19e...2be7277](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/244?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org