[GitHub] [samza] mynameborat commented on a change in pull request #1213: SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1213: SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance
URL: https://github.com/apache/samza/pull/1213#discussion_r355302152
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java
 ##########
 @@ -43,11 +43,15 @@
    * provided in one {@link java.util.Iterator} and not deserialized for
    * efficiency, allowing the implementation to optimize replay, if possible.
    *
+   * The implementers are expected to handle interrupt signals to the restoration thread and rethrow the exception to
 
 Review comment:
   Added some more documentation and created the follow up ticket to capture shutdown aware idea - https://issues.apache.org/jira/browse/SAMZA-2414

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services