You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/17 21:18:00 UTC
[jira] [Commented] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619103#comment-17619103 ]
ASF subversion and git services commented on SOLR-16300:
--------------------------------------------------------
Commit 8789520fb13a9b1736d030aefd48dde1fe22bc82 in solr's branch refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8789520fb13 ]
SOLR-16300: migrate assert to non deprecated version (#947)
Co-authored-by: Kevin Risden <kr...@apache.org>
> Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()
> -------------------------------------------------------------------------------
>
> Key: SOLR-16300
> URL: https://issues.apache.org/jira/browse/SOLR-16300
> Project: Solr
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 9.0, main (10.0)
> Reporter: Eric Pugh
> Priority: Minor
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> The org.junit.Assert that our unit tests all extend from indicates that assertThat() is deprecated, and to use org.hamcrest.MatcherAssert.assertThat() instead.
> We currently in our tests have both a mix of the assertThat() AND MatcherAssert.assertThat() methods...
> It *appears* that I can also just override the assertThat() method defined in org.junit.Assert in our base test classes to be one that calls out MatcherAssert.assertThat() which might let us change fewer lines of code..
> I'd love some direction from more experienced folks on what the right direction to go is!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org