[jira] [Commented] (OAK-5867) Oak Lucene depends on 'org.junit' OSGi package

["Robert Munteanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890104#comment-15890104 ] 

Robert Munteanu commented on OAK-5867:
--------------------------------------

oak-lucene embeds classes from oak-core:

{noformat}            <Embed-Dependency>
                lucene-*;inline=true,
              <!-- TODO FIXME OAK-3598 -->
              oak-core;inline="org/apache/jackrabbit/oak/cache/CacheStats*"
              <!-- TODO FIXME OAK-3598 -->
            </Embed-Dependency>{noformat}

With OAK-4619, a new class was added: {{oak-core/src/test/java/org/apache/jackrabbit/oak/cache/CacheStatsTest}}. This means that the class files are now embedded in oak-lucene and since they import org.junit then the import is automatically embedded by oak-lucene.

I am not sure where bnd picks them up from, as they are not in the oak-core jar file. Maybe from oak-core/target/classes? At any rate, the simplest fix would be to make the include more strict, and I'll prepare a patch for that.

> Oak Lucene depends on 'org.junit' OSGi package
> ----------------------------------------------
>
>                 Key: OAK-5867
>                 URL: https://issues.apache.org/jira/browse/OAK-5867
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.7.0
>            Reporter: Alex Parvulescu
>            Priority: Critical
>
> It seems that the {{oak-lucene}} bundle has a package dependency on {{org.junit}}. This happens on trunk only, but the weird thing is that all the changes on oak-lucene bundle have been backported to 1.6 branch and this one doesn't have the issue.
> I think this might come from oak-parent, but I'm not sure yet.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)