You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/20 03:52:48 UTC
[GitHub] [doris] englefly opened a new pull request, #11027: [refactor] rename GroupExpression.getParent() to getOwnerGroup()
englefly opened a new pull request, #11027:
URL: https://github.com/apache/doris/pull/11027
# Proposed changes
GroupExpression.getParent() returns the group which contains this expr. This name is missleading especially in tree structures.
So we change the name to getOwnerGroup.
@924060929 could u review, please?
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11027: [refactor] (Nereids) rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11027:
URL: https://github.com/apache/doris/pull/11027#issuecomment-1189946778
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11027: [refactor] (Nereids) rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
924060929 merged PR #11027:
URL: https://github.com/apache/doris/pull/11027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11027: [refactor] (Nereids) rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11027:
URL: https://github.com/apache/doris/pull/11027#issuecomment-1189946815
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #11027: [refactor] rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #11027:
URL: https://github.com/apache/doris/pull/11027#issuecomment-1189798897
please use `[xxx](Nereids)` as title prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on pull request #11027: [refactor] rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
924060929 commented on PR #11027:
URL: https://github.com/apache/doris/pull/11027#issuecomment-1189802540
wait for checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11027: [refactor] rename GroupExpression.getParent() to getOwnerGroup()
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11027:
URL: https://github.com/apache/doris/pull/11027#discussion_r925151810
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -180,8 +180,8 @@ private void mergeGroup(Group source, Group destination) {
}
}
if (groupExpressions.containsKey(groupExpression)) {
- // TODO: need to merge group recursively
- groupExpression.getParent().removeGroupExpression(groupExpression);
+ GroupExpression that = groupExpressions.get(groupExpression);
+ mergeGroup(groupExpression.getOwnerGroup(), that.getOwnerGroup());
Review Comment:
we should add some ut for merge group recursively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org