[jira] [Commented] (FLINK-3186) Deprecate DataSink.sortLocalOutput() methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072340#comment-15072340 ] 

ASF GitHub Bot commented on FLINK-3186:
---------------------------------------

GitHub user smarthi opened a pull request:

    https://github.com/apache/flink/pull/1478

    FLINK-3186: Deprecate DataSink.sortLocalOutput() methods

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/flink Flink-3186

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1478
    
----
commit 1423d766a11f2b86f97123a45ab7f2a5592612ff
Author: smarthi <sm...@apache.org>
Date:   2015-12-28T02:21:02Z

    FLINK-3186: Deprecate DataSink.sortLocalOutput() methods

----


> Deprecate DataSink.sortLocalOutput() methods
> --------------------------------------------
>
>                 Key: FLINK-3186
>                 URL: https://issues.apache.org/jira/browse/FLINK-3186
>             Project: Flink
>          Issue Type: Task
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>            Assignee: Suneel Marthi
>             Fix For: 1.0.0
>
>
> The DataSet API {{DataSink}} offers a method {{sortLocalOutput()}} to sort the output before it is handed to the {{OutputFormat}}.
> I propose to deprecate (and eventually remove) this method, because the same functionality can be achieved by using {{DataSet.sortPartition()}}. {{sortPartition()}} is more generic and has no drawbacks compared to {{sortLocalOutput()}}. Removing {{sortLocalOutput()}} would clean up the API and remove unnecessary code paths.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)