Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

["jeffkbkim (via GitHub)" <gi...@apache.org>]

jeffkbkim commented on code in PR #15312:
URL: https://github.com/apache/kafka/pull/15312#discussion_r1539875541


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -87,8 +92,8 @@ public void run() {
                 try {
                     runOnce();
                 } catch (final Throwable e) {
-                    // Swallow the exception and continue

Review Comment:
   I understand, but I am wondering why we added
   ```
   // Swallow the exception and continue
   ```
   in the first place. 
   
   The jira also asks:
   > may you give some insights on why we don't want to propagate the error to the caller? 
   
   @kirktrue can you answer this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org