[jira] [Commented] (AMQ-8349) Virtual destination consumer advisory messages are inadvertently replayed to all existing advisory consumers

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394032#comment-17394032 ] 

ASF subversion and git services commented on AMQ-8349:
------------------------------------------------------

Commit 8b99596eeb721666fe0e2bece121aed2dea81075 in activemq's branch refs/heads/main from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=8b99596 ]

AMQ-8349 - Ensure virtual destination consumer advisories are only
replayed to new advisory consumers and not existing


> Virtual destination consumer advisory messages are inadvertently replayed to all existing advisory consumers
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-8349
>                 URL: https://issues.apache.org/jira/browse/AMQ-8349
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker, Network of Brokers
>    Affects Versions: 5.16.2
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.17.0, 5.16.3
>
>
> In order to support AMQ-6027 new Virtual destination consumer advisories were created so that demand could be dynamically created due to composite destination creation across a bridge.
> When setting up a broker with several bridges I noticed that the virtual destination consumer advisory messages sent were quite high. I dug into it and it turns out that the issue was that on replay of the advisories when a bridge connected the messages are being inadvertently sent to all the existing advisory consumers again and not just the new consumer.
> What should happen is when a new bridge connects it will create a consumer on the virtual destination consumer topic and any advisories that were previously sent should be sent to ONLY that consumer. Existing consumers (usually bridge consumers) already received them so there's no reason to send them again as it causes a ton of extra traffic.
> This is how things work already for existing replay of other advisories but was simply missed when adding this feature and is a 1 line fix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)