You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/03/08 17:43:55 UTC
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/
-----------------------------------------------------------
(Updated March 8, 2016, 5:43 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
Removed initialize method from the authorizer interface.
Diffs
-----
include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
Diff: https://reviews.apache.org/r/44319/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 8, 2016, 7:16 p.m., Vinod Kone wrote:
> > src/examples/test_authorizer_module.cpp, lines 41-61
> > <https://reviews.apache.org/r/44319/diff/4/?file=1291347#file1291347line41>
> >
> > why can't you use Authorizer::create() here instead of repeating this flags extracting/parsing logic?
Refactor the code to `local::Authorizer::create(ACLs)` so I guess this is not relevant anymore.
> On March 8, 2016, 7:16 p.m., Vinod Kone wrote:
> > src/local/local.cpp, lines 225-233
> > <https://reviews.apache.org/r/44319/diff/4/?file=1291348#file1291348line225>
> >
> > I'm a little confused.
> >
> > Does this mean we allow specifying non-local authorizer as "flags.authorizers" but only allow "acls" parameter to it? What if the module writer want to send extra parameters to their module?
I refactored this code based on offline discussion.
> On March 8, 2016, 7:16 p.m., Vinod Kone wrote:
> > src/master/main.cpp, lines 363-369
> > <https://reviews.apache.org/r/44319/diff/4/?file=1291349#file1291349line363>
> >
> > I see the repetition now.
> >
> > How about we create an overload Authorizer::create(const ACLs& acls) that calls Authorizer::create(const string& name, const Parameters& parameters). Add a TODO saying that this overload should be killed once ACLs can be input as a module param instead of top level "--acls" flag.
I refactored this code based on offline discussion.
> On March 8, 2016, 7:16 p.m., Vinod Kone wrote:
> > src/tests/authorization_tests.cpp, lines 56-75
> > <https://reviews.apache.org/r/44319/diff/4/?file=1291350#file1291350line56>
> >
> > why not use Authorizer::create() instead of the repetition here?
I refactored this code based on offline discussion.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122543
-----------------------------------------------------------
On March 8, 2016, 5:43 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 5:43 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
> src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122543
-----------------------------------------------------------
src/authorizer/authorizer.cpp (line 44)
<https://reviews.apache.org/r/44319/#comment184603>
s/Using/Creating/
src/authorizer/authorizer.cpp (line 62)
<https://reviews.apache.org/r/44319/#comment184600>
new line.
src/authorizer/authorizer.cpp (line 76)
<https://reviews.apache.org/r/44319/#comment184601>
don't we need to pass params here?
src/examples/test_authorizer_module.cpp (lines 41 - 61)
<https://reviews.apache.org/r/44319/#comment184617>
why can't you use Authorizer::create() here instead of repeating this flags extracting/parsing logic?
src/examples/test_authorizer_module.cpp (line 74)
<https://reviews.apache.org/r/44319/#comment184613>
s/createAuthorizer/createLocalAuthorizer/ ?
looking at how CRAMMD5 test module was called.
src/local/local.cpp (lines 225 - 233)
<https://reviews.apache.org/r/44319/#comment184632>
I'm a little confused.
Does this mean we allow specifying non-local authorizer as "flags.authorizers" but only allow "acls" parameter to it? What if the module writer want to send extra parameters to their module?
src/master/main.cpp (lines 363 - 369)
<https://reviews.apache.org/r/44319/#comment184639>
I see the repetition now.
How about we create an overload Authorizer::create(const ACLs& acls) that calls Authorizer::create(const string& name, const Parameters& parameters). Add a TODO saying that this overload should be killed once ACLs can be input as a module param instead of top level "--acls" flag.
src/tests/authorization_tests.cpp (lines 56 - 75)
<https://reviews.apache.org/r/44319/#comment184644>
why not use Authorizer::create() instead of the repetition here?
src/tests/authorization_tests.cpp (lines 97 - 100)
<https://reviews.apache.org/r/44319/#comment184645>
why not make this a test fixture method?
```
template <typename T>
class AuthorizationTest : public MesosTest {
protected:
Parameters convert(const ACLs& acls)
{
Parameters parameters;
auto *parameter = parameters.add_parameter();
parameter->set_key("acls");
parameter->set_value(string(jsonify(JSON::Protobuf(acls))));
return parameters;
}
};
```
- Vinod Kone
On March 8, 2016, 4:43 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 4:43 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
> src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 10, 2016, 8:32 p.m., Vinod Kone wrote:
> > src/master/main.cpp, line 372
> > <https://reviews.apache.org/r/44319/diff/6/?file=1293232#file1293232line372>
> >
> > So, we create non-default authorizer if --authorizers specifies a non-default name but create the default authorizer only if --acls is present (irrespective of whether --authorizers says "local)".
> >
> > I think those semantics are a bit weird to grok. IIRC, we did it that way for backwards compatibility with old releases that didn't have "--authorizers" flag? We should atleast mention this behavior in the flags help.
>
> Alexander Rojas wrote:
> That is not how the block reads, that block is equivalent to:
>
> ```c++
> if (authorizerName != master::DEFAULT_AUTHORIZER) {
> LOG(INFO) << "Creating '" << authorizerName << "' authorizer";
>
> create = Authorizer::create(authorizerName);
> } else { // authorizerName is the default authorizer at this point!
> if (flags.acls.isSome()) {
> LOG(INFO) << "Creating default '" << authorizerName << "' authorizer";
>
> create = Authorizer::create(flags.acls.get());
> }
> }
> ```
>
> So `--authorizer` has to say _local_ **and** `--acls` have to be present.
I changed the code to the snippet above, so there are no confusions in the future.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122961
-----------------------------------------------------------
On March 9, 2016, 3:06 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 3:06 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 10, 2016, 8:32 p.m., Vinod Kone wrote:
> > src/master/main.cpp, line 372
> > <https://reviews.apache.org/r/44319/diff/6/?file=1293232#file1293232line372>
> >
> > So, we create non-default authorizer if --authorizers specifies a non-default name but create the default authorizer only if --acls is present (irrespective of whether --authorizers says "local)".
> >
> > I think those semantics are a bit weird to grok. IIRC, we did it that way for backwards compatibility with old releases that didn't have "--authorizers" flag? We should atleast mention this behavior in the flags help.
That is not how the block reads, that block is equivalent to:
```c++
if (authorizerName != master::DEFAULT_AUTHORIZER) {
LOG(INFO) << "Creating '" << authorizerName << "' authorizer";
create = Authorizer::create(authorizerName);
} else { // authorizerName is the default authorizer at this point!
if (flags.acls.isSome()) {
LOG(INFO) << "Creating default '" << authorizerName << "' authorizer";
create = Authorizer::create(flags.acls.get());
}
}
```
So `--authorizer` has to say _local_ **and** `--acls` have to be present.
> On March 10, 2016, 8:32 p.m., Vinod Kone wrote:
> > src/authorizer/local/authorizer.cpp, line 364
> > <https://reviews.apache.org/r/44319/diff/6/?file=1293229#file1293229line364>
> >
> > s/acls/acls_/
Note that this naming is discouraged by the style guide:
> Prefer trailing underscores for use as member fields (but not required). Some trailing underscores are used to distinguish between similar variables in the same scope (think prime symbols), but this should be avoided as much as possible, including removing existing instances in the code base.
> On March 10, 2016, 8:32 p.m., Vinod Kone wrote:
> > src/local/local.cpp, line 244
> > <https://reviews.apache.org/r/44319/diff/6/?file=1293231#file1293231line244>
> >
> > s/authorizer/authorizer_/
Note that this naming is discouraged by the style guide:
> Prefer trailing underscores for use as member fields (but not required). Some trailing underscores are used to distinguish between similar variables in the same scope (think prime symbols), but this should be avoided as much as possible, including removing existing instances in the code base.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122961
-----------------------------------------------------------
On March 9, 2016, 3:06 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 3:06 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122961
-----------------------------------------------------------
Fix it, then Ship it!
Looks good. Some minor comments.
include/mesos/authorizer/authorizer.hpp (line 61)
<https://reviews.apache.org/r/44319/#comment185058>
s/returned value/the authorizer/
src/authorizer/local/authorizer.hpp (line 50)
<https://reviews.apache.org/r/44319/#comment185061>
Add a comment for this?
src/authorizer/local/authorizer.cpp (line 353)
<https://reviews.apache.org/r/44319/#comment185063>
s/stringAcls/acls/
src/authorizer/local/authorizer.cpp (line 364)
<https://reviews.apache.org/r/44319/#comment185065>
s/acls/acls_/
src/local/local.cpp (line 228)
<https://reviews.apache.org/r/44319/#comment185066>
s/create/authorizer/
src/local/local.cpp (line 243)
<https://reviews.apache.org/r/44319/#comment185067>
s/authorizer/authorizer_/
src/master/main.cpp (line 372)
<https://reviews.apache.org/r/44319/#comment185068>
So, we create non-default authorizer if --authorizers specifies a non-default name but create the default authorizer only if --acls is present (irrespective of whether --authorizers says "local)".
I think those semantics are a bit weird to grok. IIRC, we did it that way for backwards compatibility with old releases that didn't have "--authorizers" flag? We should atleast mention this behavior in the flags help.
src/tests/cluster.cpp (line 175)
<https://reviews.apache.org/r/44319/#comment185069>
s/create/authorizer/
- Vinod Kone
On March 9, 2016, 2:06 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 2:06 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review123210
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 11, 2016, 1:45 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 1:45 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed initialize method from the authorizer interface.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/44319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/
-----------------------------------------------------------
(Updated March 11, 2016, 2:45 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Addresses Vinod's issues.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
Removed initialize method from the authorizer interface.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
Diff: https://reviews.apache.org/r/44319/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/
-----------------------------------------------------------
(Updated March 9, 2016, 3:06 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
Removed initialize method from the authorizer interface.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
Diff: https://reviews.apache.org/r/44319/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 44319: Removed initialize method from the
authorizer interface.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/
-----------------------------------------------------------
(Updated March 9, 2016, 5:54 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Adresses issues reported by Vinod.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
Removed initialize method from the authorizer interface.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
src/examples/test_authorizer_module.cpp 95d77fbff0cdfdb360a8597fbba28404b59d0042
src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
Diff: https://reviews.apache.org/r/44319/diff/
Testing
-------
make check
Thanks,
Alexander Rojas