Re: [PR] List every ClientHello extension type on OpenSSL [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on PR #13809:
URL: https://github.com/apache/trafficserver/pull/13809#issuecomment-6070159780

   Thanks, agreed. I reworked the patch that way:
   
   - `get_extension_types()` now returns the raw ClientHello extension list on OpenSSL, falling back to `SSL_client_hello_get1_extensions_present` if the raw message doesn't parse. `TSRawExtensionTypeList`, `get_extension_types_raw()`, `raw_begin()`/`raw_end()`, the extra `InkAPI.cc` iterators and the `ja4/tls_client_hello_summary.cc` change are gone.
   - `upgrading.en.rst` now has a release note that JA3/JA4 values on OpenSSL change for clients sending extensions OpenSSL doesn't recognize.
   - `TSClientHello.en.rst` notes that `TSClientHelloExtensionGet()` still can't return the contents of those extensions on OpenSSL.
   
   The message callback, the parser and both tests are unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org