[GitHub] [superset] cccs-rc commented on a change in pull request #15153: [WIP] Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

[GitBox <gi...@apache.org>]

cccs-rc commented on a change in pull request #15153:
URL: https://github.com/apache/superset/pull/15153#discussion_r651180481



##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -113,6 +125,11 @@ export default function DataSourcePanel({
     columns,
     metrics,
   });
+  const [showAllMetrics, setShowAllMetrics] = useState(false);
+  const [showAllColumns, setShowAllColumns] = useState(false);
+
+  const DEFAULT_MAX_COLUMNS_LENGTH = 50;
+  const DEFAULT_MAX_METRIC_LENGTH = 50;

Review comment:
       Biggest nitpick ever. 
   ```suggestion
     const DEFAULT_MAX_METRICS_LENGTH = 50;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org