You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "tiltwind (via GitHub)" <gi...@apache.org> on 2023/05/05 16:08:29 UTC
[GitHub] [dubbo-go] tiltwind opened a new pull request, #2312: [WIP] upgrade hessian2 to test bug fix
tiltwind opened a new pull request, #2312:
URL: https://github.com/apache/dubbo-go/pull/2312
THIS PR IS CURRENTLY WIP.
upgrade hessian2 to test bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #2312: upgrade hessian2 to fix java wrapper object decoding bug
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wongoo commented on pull request #2312: [WIP] upgrade hessian2 to test bug fix
Posted by "wongoo (via GitHub)" <gi...@apache.org>.
wongoo commented on PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312#issuecomment-1536948327
There is an error in the integration test. This PR only contains some fix for hessian serialization. But the error is about registering server. Can anyone help to see what's problem?
```
2023-05-05T17:04:22.820Z INFO config/config_loader.go:95 Starting register instance address &{10.1.0.86:20000 myApp 10.1.0.86 20000 true true map[dubbo.endpoints:[{"port":20000,"protocol":"dubbo"}] dubbo.metadata-service.url-params:{"application":"myApp","group":"myApp","port":"35667","protocol":"dubbo","release":"dubbo-golang-3.0.4","timestamp":"1683306262","version":"1.0.0"} dubbo.metadata.revision:4260813324 dubbo.metadata.storage-type:local dubbo.subscribed-services.revision:0] <nil> []}
panic: could not register the instance. myApp: Polaris-1004(ErrCodeAPITimeoutError): fail to do register after retry 1 times, cause: Polaris-1007(ErrCodeNetworkError): fail to get connection, opKey RegisterInstance, cause: fail to connect to 183.47.111.80:8091, timeout is 500.114724ms, service is {ServiceKey: {namespace: "Polaris", service: "polaris-default"}, ClusterType: builtin}, because context deadline exceeded
goroutine 1 [running]:
dubbo.apache.org/dubbo-go/v3/config.registerServiceInstance()
/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/config_loader.go:98 +0x28b
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Start.func1()
/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:216 +0x4f
sync.(*Once).doSlow(0x40f8a7, 0xa8)
/opt/hostedtoolcache/go/1.17.13/x64/src/sync/once.go:68 +0xd2
sync.(*Once).Do(...)
/opt/hostedtoolcache/go/1.17.13/x64/src/sync/once.go:59
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Start(0x1a41ae0)
/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:210 +0x46
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Init(0xc00012f4a0)
/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:205 +0x565
dubbo.apache.org/dubbo-go/v3/config.Load({0x0, 0x1804800, 0xc0000001a0})
/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/config_loader.go:59 +0xb1
main.main()
/home/runner/work/dubbo-go/dubbo-go/samples/polaris/registry/go-server/cmd/server.go:82 +0x25
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2312: [WIP] upgrade hessian2 to test bug fix
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312#issuecomment-1537062724
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2312)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2312: [WIP] upgrade hessian2 to test bug fix
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312#issuecomment-1536498323
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2312)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2312: [WIP] upgrade hessian2 to test bug fix
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312#issuecomment-1536474844
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2312)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2312: upgrade hessian2 to fix java wrapper object decoding bug
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2312:
URL: https://github.com/apache/dubbo-go/pull/2312#issuecomment-1569653313
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2312](https://app.codecov.io/gh/apache/dubbo-go/pull/2312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f35b3f4) into [main](https://app.codecov.io/gh/apache/dubbo-go/commit/4b13d2b8637a4356b33f992c8208ec7475ef80ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4b13d2b) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #2312 +/- ##
==========================================
+ Coverage 44.05% 44.15% +0.09%
==========================================
Files 285 294 +9
Lines 17669 17845 +176
==========================================
+ Hits 7784 7879 +95
- Misses 9057 9128 +71
- Partials 828 838 +10
```
[see 30 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go/pull/2312/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org