You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/18 06:39:54 UTC

[GitHub] [cloudstack] utchoang commented on a change in pull request #4744: UI: Fix update template permission with different domain

utchoang commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r596587906



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       Adding `isrecursive` will display the subdomain accounts, but when authorizing those accounts, an error will arise. So I don't think it's necessary. What do you think?
   ![image](https://user-images.githubusercontent.com/13766648/111583323-cca0f980-87ee-11eb-9e5b-9cd80109917c.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583375-e3475080-87ee-11eb-9a47-c04d07c856fe.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583447-07a32d00-87ef-11eb-928a-20e662d6a3f1.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org