You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2015/04/28 07:53:00 UTC
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/5734
[SPARK-7187] SerializationDebugger should not crash user code
@rxin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark ser-deb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5734
----
commit 57d0ef4369a6641a7615d6cc66eeadc6e47d80c4
Author: Andrew Or <an...@databricks.com>
Date: 2015-04-28T05:41:16Z
try catch improveException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5734#issuecomment-96963057
Merging in master & branch-1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5734#issuecomment-96924806
[Test build #31120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31120/consoleFull) for PR 5734 at commit [`57d0ef4`](https://github.com/apache/spark/commit/57d0ef4369a6641a7615d6cc66eeadc6e47d80c4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5734#issuecomment-96939472
[Test build #31122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31122/consoleFull) for PR 5734 at commit [`e8aad6c`](https://github.com/apache/spark/commit/e8aad6c5a49b032a0c066109d975ec4ccf4a0079).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5734#issuecomment-96959846
[Test build #31120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31120/consoleFull) for PR 5734 at commit [`57d0ef4`](https://github.com/apache/spark/commit/57d0ef4369a6641a7615d6cc66eeadc6e47d80c4).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5734#issuecomment-96965870
[Test build #31122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31122/consoleFull) for PR 5734 at commit [`e8aad6c`](https://github.com/apache/spark/commit/e8aad6c5a49b032a0c066109d975ec4ccf4a0079).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait LDAOptimizer`
* `class EMLDAOptimizer extends LDAOptimizer`
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7187] SerializationDebugger should not ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5734#discussion_r29216045
--- Diff: core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala ---
@@ -35,8 +35,15 @@ private[serializer] object SerializationDebugger extends Logging {
*/
def improveException(obj: Any, e: NotSerializableException): NotSerializableException = {
if (enableDebugging && reflect != null) {
- new NotSerializableException(
- e.getMessage + "\nSerialization stack:\n" + find(obj).map("\t- " + _).mkString("\n"))
+ try {
+ new NotSerializableException(
+ e.getMessage + "\nSerialization stack:\n" + find(obj).map("\t- " + _).mkString("\n"))
+ } catch {
+ case e2: Exception =>
--- End diff --
case NonFatal(e2)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org