You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2016/11/08 20:10:17 UTC
kafka git commit: MINOR: remove commented out code and
System.out.println
Repository: kafka
Updated Branches:
refs/heads/trunk 471a2ab17 -> 92287849e
MINOR: remove commented out code and System.out.println
Remove commented out code and System.out.println from KTableKTableJoinIntegrationTest
Author: Damian Guy <da...@gmail.com>
Reviewers: Matthias J. Sax, Eno Thereska, Guozhang Wang
Closes #2092 from dguy/cleanup-comments
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/92287849
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/92287849
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/92287849
Branch: refs/heads/trunk
Commit: 92287849e46ee0dad360fcd971c6207aa11777a7
Parents: 471a2ab
Author: Damian Guy <da...@gmail.com>
Authored: Tue Nov 8 12:10:13 2016 -0800
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Tue Nov 8 12:10:13 2016 -0800
----------------------------------------------------------------------
.../KTableKTableJoinIntegrationTest.java | 31 --------------------
1 file changed, 31 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/92287849/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java
----------------------------------------------------------------------
diff --git a/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java b/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java
index 2cd3859..5a0d368 100644
--- a/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java
@@ -71,49 +71,26 @@ public class KTableKTableJoinIntegrationTest {
public static Object[] parameters() {
return new Object[][]{
{JoinType.INNER, JoinType.INNER, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", null)
)},
{JoinType.INNER, JoinType.LEFT, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", null)
)},
{JoinType.INNER, JoinType.OUTER, Arrays.asList(
new KeyValue<>("a", "null-A3"),
new KeyValue<>("b", "null-B3"),
new KeyValue<>("c", "null-C3"),
-// new KeyValue<>("a", "null-A3"),
-// new KeyValue<>("b", "null-B3"),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", "null-C3")
)},
{JoinType.LEFT, JoinType.INNER, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
new KeyValue<>("a", "A1-null-A3"),
new KeyValue<>("b", "B1-null-B3"),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", null)
)},
{JoinType.LEFT, JoinType.LEFT, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
new KeyValue<>("a", "A1-null-A3"),
new KeyValue<>("b", "B1-null-B3"),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", null)
)},
{JoinType.LEFT, JoinType.OUTER, Arrays.asList(
new KeyValue<>("a", "null-A3"),
@@ -122,21 +99,14 @@ public class KTableKTableJoinIntegrationTest {
new KeyValue<>("a", "A1-null-A3"),
new KeyValue<>("b", "B1-null-B3"),
new KeyValue<>("b", "B1-B2-B3")//,
-// new KeyValue<>("c", "null-C3")
)},
{JoinType.OUTER, JoinType.INNER, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
new KeyValue<>("a", "A1-null-A3"),
new KeyValue<>("b", "B1-null-B3"),
new KeyValue<>("b", "B1-B2-B3"),
new KeyValue<>("c", "null-C2-C3")
)},
{JoinType.OUTER, JoinType.LEFT, Arrays.asList(
-// new KeyValue<>("a", null),
-// new KeyValue<>("b", null),
-// new KeyValue<>("c", null),
new KeyValue<>("a", "A1-null-A3"),
new KeyValue<>("b", "B1-null-B3"),
new KeyValue<>("b", "B1-B2-B3"),
@@ -262,7 +232,6 @@ public class KTableKTableJoinIntegrationTest {
@Test
public void KTableKTableJoin() throws Exception {
- System.out.println("join: " + joinType1 + "-" + joinType2);
streamsConfig.put(StreamsConfig.APPLICATION_ID_CONFIG, joinType1 + "-" + joinType2 + "-ktable-ktable-join");
streams = prepareTopology();