You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/06 18:40:12 UTC
[GitHub] [flink-kubernetes-operator] dependabot[bot] opened a new pull request, #158: Bump checkstyle from 8.14 to 8.29
dependabot[bot] opened a new pull request, #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.14 to 8.29.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/checkstyle/checkstyle/releases">checkstyle's releases</a>.</em></p>
<blockquote>
<h2>checkstyle-8.29</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.29">https://checkstyle.org/releasenotes.html#Release_8.29</a></p>
<h2>checkstyle-8.28</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.28">https://checkstyle.org/releasenotes.html#Release_8.28</a></p>
<h2>checkstyle-8.27</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.27">https://checkstyle.org/releasenotes.html#Release_8.27</a></p>
<h2>checkstyle-8.26</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.26">https://checkstyle.org/releasenotes.html#Release_8.26</a></p>
<h2>checkstyle-8.25</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.25">https://checkstyle.org/releasenotes.html#Release_8.25</a></p>
<h2>checkstyle-8.24</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.24">https://checkstyle.org/releasenotes.html#Release_8.24</a></p>
<h2>checkstyle-8.23</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.23">https://checkstyle.org/releasenotes.html#Release_8.23</a></p>
<h2>checkstyle-8.22</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.22">https://checkstyle.org/releasenotes.html#Release_8.22</a></p>
<h2>checkstyle-8.21</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.21">https://checkstyle.org/releasenotes.html#Release_8.21</a></p>
<h2>checkstyle-8.20</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.20">https://checkstyle.org/releasenotes.html#Release_8.20</a></p>
<h2>checkstyle-8.19</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.19">https://checkstyle.org/releasenotes.html#Release_8.19</a></p>
<h2>checkstyle-8.18</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.18">https://checkstyle.org/releasenotes.html#Release_8.18</a></p>
<h2>checkstyle-8.17</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.17">https://checkstyle.org/releasenotes.html#Release_8.17</a></p>
<h2>checkstyle-8.16</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.16">https://checkstyle.org/releasenotes.html#Release_8.16</a></p>
<h2>checkstyle-8.15</h2>
<p><a href="https://checkstyle.org/releasenotes.html#Release_8.15">https://checkstyle.org/releasenotes.html#Release_8.15</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/checkstyle/checkstyle/commit/8933d03c910f8c6243795bc744fbbd0eaed0eb23"><code>8933d03</code></a> [maven-release-plugin] prepare release checkstyle-8.29</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/bd45909e6345b2d3ef5c5472d35a3ad926a31eb9"><code>bd45909</code></a> Issue <a href="https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/7487">#7487</a>: refactor code to use DetailAST.hasChildren()</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/317e51f9b8e86bdce512be79a5f8c444c674ffae"><code>317e51f</code></a> Issue <a href="https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/7487">#7487</a>: add method hasChildren() to DetailAST</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/89b4dcd4d51d0dcc0b1347bcc7f4f3c533fefaa4"><code>89b4dcd</code></a> Issue <a href="https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/3238">#3238</a>: Java 8 Grammar: annotations on arrays and varargs</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/252cd89425776de63e689db934cc110ecd9a9dfc"><code>252cd89</code></a> dependency: bump junit-pioneer from 0.5.1 to 0.5.2</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/2ee26156a20f54c86b31c75a4d930f03c781f941"><code>2ee2615</code></a> dependency: bump junit.version from 5.5.2 to 5.6.0</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/4ed7cb8e49091f0966f82241317a33601e0ce464"><code>4ed7cb8</code></a> minor: add space before xml comment end '-->' to ease reading and make links ...</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/c46a16d177e6797895b195c288ae9a9a096254b8"><code>c46a16d</code></a> Issue <a href="https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/7468">#7468</a>: disable 'external-parameter-entities' feature by default</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/dfed7949c3714dceb0318e4381f00e7fb5d5dfe3"><code>dfed794</code></a> minor: add missing test case to SuperCloneCheckTest</li>
<li><a href="https://github.com/checkstyle/checkstyle/commit/24e7bdf9987c0da90d474a25bc9d714a2c9f2f23"><code>24e7bdf</code></a> dependency: bump antlr4.version from 4.7.2 to 4.8-1</li>
<li>Additional commits viewable in <a href="https://github.com/checkstyle/checkstyle/compare/checkstyle-8.14...checkstyle-8.29">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/flink-kubernetes-operator/network/alerts).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] dependabot[bot] commented on pull request #158: Bump checkstyle from 8.14 to 8.29
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1091197974
OK, I won't notify you about version 8.29.x again, unless you re-open this PR or update to a 8.29.x release yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on code in PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#discussion_r1401876529
##########
pom.xml:
##########
@@ -232,7 +232,7 @@ under the License.
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<!-- Note: match version with docs/flinkDev/ide_setup.md -->
- <version>8.14</version>
+ <version>8.29</version>
Review Comment:
<img width="542" alt="image" src="https://github.com/apache/flink-kubernetes-operator/assets/837221/617c0fc7-0893-42f7-af7e-3cf8b80203a1">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm closed pull request #158: Bump checkstyle from 8.14 to 8.29
URL: https://github.com/apache/flink-kubernetes-operator/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] MartijnVisser commented on pull request #158: Bump checkstyle from 8.14 to 8.29
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1091197873
We're currently not upgrading Checkstyle to keep a consistent developer experience for all Flink maintainers.
https://github.com/dependabot ignore this minor version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822998814
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822552122
CC @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822998715
Agreed, let's leave this as-is for now. Upgrading also requires more work. I tried locally with 8.18 but it seems we need at least 8.29 to fix all vulnerabilities which depends on a newer Maven checkstyle plugin version which in turn requires adjustments to the rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] MartijnVisser closed pull request #158: Bump checkstyle from 8.14 to 8.29
Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #158: Bump checkstyle from 8.14 to 8.29
URL: https://github.com/apache/flink-kubernetes-operator/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822551881
Why can't we upgrade checkstyle? I tried out 8.29 it passed fine. Reopening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822686725
> Why can't we upgrade checkstyle? I tried out 8.29 it passed fine. Reopening.
It's a breaking change for all developers, since it requires you to reconfigure your IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822748964
> I agree to keep this consistent
Do you want to push for updating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump checkstyle from 8.14 to 8.29 [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/158#issuecomment-1822742207
Makes sense @MartijnVisser thanks for pointing it out. I agree to keep this consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org