You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by wangyulin <gi...@git.apache.org> on 2018/06/12 00:20:07 UTC
[GitHub] commons-pool pull request #7: Refactor PooledObject and BaseGenericObjectPoo...
GitHub user wangyulin opened a pull request:
https://github.com/apache/commons-pool/pull/7
Refactor PooledObject and BaseGenericObjectPool
```PooledObject``` should not pay attention to ```idleObjects``` of ```GenericObjectPool```, so there should be no ```idleQueue.offerFirst (this)``` operation in ```PooledObject```.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyulin/commons-pool dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-pool/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit dce040eef545b781c000e583568e761b19f4800c
Author: jieyebing <ji...@...>
Date: 2018-06-12T00:11:52Z
Refactor PooledObject and BaseGenericObjectPool
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
@garydgregory Thank you for the patient answer, I understand.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool pull request #7: Refactor PooledObject and BaseGenericObjectPoo...
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin closed the pull request at:
https://github.com/apache/commons-pool/pull/7
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the operation of PooledObject.
At present, can this be considered this way?
If there is a need to add an interface, when can it be added?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/7
If by "moving" you mean deleting a method from an interface, that would break binary compatibility, which we cannot do outside of a major release (where we would change the package name and Maven artifact id.) You _can_ add an interface any time since that does not break binary compatibility.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
**Check checkAPIcompatibility failed:**
- org.apache.commons.pool2.PooledObject:
Method 'public void setState(org.apache.commons.pool2.PooledObjectState)' has been added to an interface
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
@garydgregory In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the operation of PooledObject.
At present, can this be considered this way?
If there is a need to add an interface, when can it be added?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by wangyulin <gi...@git.apache.org>.
Github user wangyulin commented on the issue:
https://github.com/apache/commons-pool/pull/7
Add ```getState()``` on ```PooledObject```, checkAPIcompatibility failed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/7
Right, we cannot add method to existing interfaces outside of a major release.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org