You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2018/11/26 12:02:00 UTC

[jira] [Created] (OAK-7919) Imporove logging for ExternalLoginModule.java

Antonio Sanso created OAK-7919:
----------------------------------

             Summary: Imporove logging for ExternalLoginModule.java
                 Key: OAK-7919
                 URL: https://issues.apache.org/jira/browse/OAK-7919
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: auth-external
            Reporter: Antonio Sanso


It would be nice to improve the logging in the {{ExternalLoginModule.java}} class

In particular IMHO it would be better to increase the log level in this snippet
{code:java}
        } catch (LoginException e) {
            log.debug("IDP {} throws login exception for '{}': {}", idp.getName(), logId, e.getMessage());
            throw e;
        } catch (Exception e) {
            log.debug("SyncHandler {} throws sync exception for '{}'", syncHandler.getName(), logId, e);
            LoginException le = new LoginException("Error while syncing user.");
            le.initCause(e);
            throw le;
        }{code}

See https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L254



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)