You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Chris Geer <ch...@cxtsoftware.com> on 2012/07/21 07:02:53 UTC
Review Request: Update SSO for Rave 0.14-SNAPSHOT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6075/
-----------------------------------------------------------
Review request for rave.
Description
-------
Update SSO for Rave 0.14-SNAPSHOT
This addresses bug RAVE-726.
https://issues.apache.org/jira/browse/RAVE-726
Diffs
-----
/sandbox/rave-extensions/rave-extension-sso/pom.xml 1363240
/sandbox/rave-extensions/rave-extension-sso/src/main/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandler.java 1363240
/sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/filter/SSORequestHeaderAuthenticationFilterTest.java 1363240
/sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandlerTest.java 1363240
Diff: https://reviews.apache.org/r/6075/diff/
Testing
-------
Tested locally and ran into some issues with creating new accounts. I think it might be because I'm instantiating a UserImpl (POJO) object and not a JPA User so I'm looking for a second opinion on the best way to handle this (and make it work with multiple backends potentially).
Thanks,
Chris Geer
Re: Review Request: Update SSO for Rave 0.14-SNAPSHOT
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On July 28, 2012, 6:26 p.m., Matt Franklin wrote:
> > Not sure why this isn't working. The only thing I saw is you are not setting a default page layout...
It is working, was just running into some odd issues that I now think are unrelated. I'll commit these changes.
> On July 28, 2012, 6:26 p.m., Matt Franklin wrote:
> > /sandbox/rave-extensions/rave-extension-sso/src/main/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandler.java, line 106
> > <https://reviews.apache.org/r/6075/diff/1/?file=125849#file125849line106>
> >
> > Why are you no longer setting the default page layout?
My mistake, this has been fixed.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6075/#review9558
-----------------------------------------------------------
On July 21, 2012, 5:02 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6075/
> -----------------------------------------------------------
>
> (Updated July 21, 2012, 5:02 a.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Update SSO for Rave 0.14-SNAPSHOT
>
>
> This addresses bug RAVE-726.
> https://issues.apache.org/jira/browse/RAVE-726
>
>
> Diffs
> -----
>
> /sandbox/rave-extensions/rave-extension-sso/pom.xml 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/main/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandler.java 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/filter/SSORequestHeaderAuthenticationFilterTest.java 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandlerTest.java 1363240
>
> Diff: https://reviews.apache.org/r/6075/diff/
>
>
> Testing
> -------
>
> Tested locally and ran into some issues with creating new accounts. I think it might be because I'm instantiating a UserImpl (POJO) object and not a JPA User so I'm looking for a second opinion on the best way to handle this (and make it work with multiple backends potentially).
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Update SSO for Rave 0.14-SNAPSHOT
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6075/#review9558
-----------------------------------------------------------
Not sure why this isn't working. The only thing I saw is you are not setting a default page layout...
/sandbox/rave-extensions/rave-extension-sso/src/main/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandler.java
<https://reviews.apache.org/r/6075/#comment20418>
Why are you no longer setting the default page layout?
- Matt Franklin
On July 21, 2012, 5:02 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6075/
> -----------------------------------------------------------
>
> (Updated July 21, 2012, 5:02 a.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Update SSO for Rave 0.14-SNAPSHOT
>
>
> This addresses bug RAVE-726.
> https://issues.apache.org/jira/browse/RAVE-726
>
>
> Diffs
> -----
>
> /sandbox/rave-extensions/rave-extension-sso/pom.xml 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/main/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandler.java 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/filter/SSORequestHeaderAuthenticationFilterTest.java 1363240
> /sandbox/rave-extensions/rave-extension-sso/src/test/java/org/apache/rave/portal/security/impl/DefaultSSOLoginHandlerTest.java 1363240
>
> Diff: https://reviews.apache.org/r/6075/diff/
>
>
> Testing
> -------
>
> Tested locally and ran into some issues with creating new accounts. I think it might be because I'm instantiating a UserImpl (POJO) object and not a JPA User so I'm looking for a second opinion on the best way to handle this (and make it work with multiple backends potentially).
>
>
> Thanks,
>
> Chris Geer
>
>