You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/18 12:43:40 UTC
[GitHub] [skywalking-rust] tisonkun opened a new pull request #18: fix ignore /e2e/target folder
tisonkun opened a new pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18
Signed-off-by: tison <wa...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044469569
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e509254) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/a437859f5faa0aa13704a607a6ae6600228cd1ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a437859) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 9 9
Lines 279 279
=======================================
Hits 237 237
Misses 42 42
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a437859...e509254](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] kezhenxu94 commented on a change in pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#discussion_r810020471
##########
File path: e2e/Cargo.lock
##########
@@ -1,3 +1,5 @@
+# This file is automatically @generated by Cargo.
+# It is not intended for manual editing.
Review comment:
These lines are present in this file already, please either remove these or remove line 20-21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044484432
e2e fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] tisonkun commented on a change in pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#discussion_r810034491
##########
File path: e2e/Cargo.lock
##########
@@ -1,3 +1,5 @@
+# This file is automatically @generated by Cargo.
+# It is not intended for manual editing.
Review comment:
OK. I'll regenerate the lock file and it should converge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] tisonkun commented on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044507865
@wu-sheng from the log it seems that the output are semantically compatible but the representation differs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044549746
I rerun, but still fails. Strange. I can't see the issue from the logs too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter edited a comment on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044469569
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (522581d) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/a437859f5faa0aa13704a607a6ae6600228cd1ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a437859) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 9 9
Lines 279 279
=======================================
Hits 237 237
Misses 42 42
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a437859...522581d](https://codecov.io/gh/apache/skywalking-rust/pull/18?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] kezhenxu94 commented on pull request #18: fix ignore /e2e/target folder
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #18:
URL: https://github.com/apache/skywalking-rust/pull/18#issuecomment-1044581389
CI failure is not because of the expected data, but because of the response code (`response.status_code != 200`), check this,
https://github.com/apache/skywalking-rust/blob/a437859f5faa0aa13704a607a6ae6600228cd1ab/e2e/run_e2e.py#L38-L49
so problem might be there is queuing or delay in sending data to backend from the agent, just guess.
Also I think we should add retry for the validation as well despite of that my guess above is wrong
https://github.com/apache/skywalking-rust/blob/a437859f5faa0aa13704a607a6ae6600228cd1ab/e2e/run_e2e.py#L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org