[GitHub] [airflow] bbovenzi commented on a diff in pull request #23152: Fix error handling in Grid view

[GitBox <gi...@apache.org>]

bbovenzi commented on code in PR #23152:
URL: https://github.com/apache/airflow/pull/23152#discussion_r855400240


##########
airflow/www/views.py:
##########
@@ -513,13 +513,15 @@ def get_task_stats_from_query(qry):
     return data
 
 
-def redirect_or_json(origin, msg, status=""):
+def redirect_or_json(origin, msg, status="", status_code=200):
     """
     Some endpoints are called by javascript,
     returning json will allow us to more elegantly handle side-effects in-page
     """
     if request.headers.get('Accept') == 'application/json':
-        return {'status': status, 'message': msg}
+        if status == 'error' and status_code == 200:
+            status_code = 500
+        return Response(response=msg, status=status_code, mimetype="application/json")

Review Comment:
   I think so, because a 4xx or 5xx error code should make Response an error already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org