You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2015/04/23 17:39:02 UTC

svn commit: r1675643 - /subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h

Author: julianfoad
Date: Thu Apr 23 15:39:02 2015
New Revision: 1675643

URL: http://svn.apache.org/r1675643
Log:
On the 'move-tracking-2' branch: Note that svn_branch_subtree_t
should be used in implementing svn_branch_state_t.

* subversion/include/private/svn_branch.h
  (svn_branch_state_t,
   svn_branch_subtree_t): Add comments.

Modified:
    subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h

Modified: subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h
URL: http://svn.apache.org/viewvc/subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h?rev=1675643&r1=1675642&r2=1675643&view=diff
==============================================================================
--- subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h (original)
+++ subversion/branches/move-tracking-2/subversion/include/private/svn_branch.h Thu Apr 23 15:39:02 2015
@@ -190,6 +190,10 @@ struct svn_branch_state_t
   /* --- Contents of this object --- */
 
   /* EID -> svn_branch_el_rev_content_t mapping. */
+  /* ### TODO: This should use an svn_branch_subtree_t instead of E_MAP and
+   *     ROOT_EID. And the immediate subbranches would be directly in there,
+   *     instead of (or as well as) being in a single big list in REV_ROOT.
+   *     And a whole bunch of methods would be common to both. */
   apr_hash_t *e_map;
 
 };
@@ -332,6 +336,9 @@ svn_branch_el_rev_content_equal(const sv
  * The EIDs used in here may be considered either as global EIDs (known to
  * the repo), or as local stand-alone EIDs (in their own local name-space),
  * according to the context.
+ *
+ * ### TODO: This should be used in the implementation of svn_branch_state_t.
+ *     A whole bunch of methods would be common to both.
  */
 typedef struct svn_branch_subtree_t
 {