You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2023/07/12 21:00:20 UTC

[GitHub] [ozone] smengcl opened a new pull request, #5055: HDDS-8294. mvn clean should remove build and node_modules dir generated during maven build under Recon src

smengcl opened a new pull request, #5055:
URL: https://github.com/apache/ozone/pull/5055

   ## What changes were proposed in this pull request?
   
   It is noticed that because the pnpm build during Recon compilation doesn't put the files under `./target`, they are not removed by `mvn clean` by default. This PR aims to address that.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8294
   
   ## How was this patch tested?
   
   - [x] Test locally that `mvn clean` removes the two directories recursively, including the dir itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #5055: HDDS-8294. mvn clean should remove frontend build artifacts stored in Recon src

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5055:
URL: https://github.com/apache/ozone/pull/5055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] smengcl commented on pull request #5055: HDDS-8294. mvn clean should remove frontend build artifacts stored in Recon src

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #5055:
URL: https://github.com/apache/ozone/pull/5055#issuecomment-1636361940

   Thanks @adoroszlai and @szetszwo for reviewing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #5055: HDDS-8294. mvn clean should remove frontend build artifacts stored in Recon src

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5055:
URL: https://github.com/apache/ozone/pull/5055#issuecomment-1636298342

   Thanks @szetszwo for the review and for reporting this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org