You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Ritabrata Moitra (JIRA)" <ji...@apache.org> on 2018/10/05 08:56:00 UTC

[jira] [Commented] (KAFKA-7461) Connect Values converter should have coverage of logical types

    [ https://issues.apache.org/jira/browse/KAFKA-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639498#comment-16639498 ] 

Ritabrata Moitra commented on KAFKA-7461:
-----------------------------------------

I would like to take a dab at this. 

It seems that coverage is missing for the following types (from scan coverage) - 
 # Boolean
 # Byte
 # Short ( Only tested via map )
 # Integer
 # Float
 # Double
 # Struct
 # Time
 # Date
 # Timestamp
 # Decimal 



Is there anything that I might have missed out? Also is there a priority order for these? 

> Connect Values converter should have coverage of logical types
> --------------------------------------------------------------
>
>                 Key: KAFKA-7461
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7461
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 1.1.1, 2.0.0
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>            Priority: Blocker
>              Labels: newbie, test
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Per fix from KAFKA-7460, we've got some gaps in testing for the Values converter added in KIP-145, in particular for logical types. It looks like there are a few other gaps (e.g. from quick scan of coverage, maybe the float types as well), but logical types seem to be the bulk other than trivial wrapper methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)