You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/29 19:08:45 UTC
[PR] test(desktop): story-cover agent graph failure and edge states [maka]
liuxiaocs7 opened a new pull request, #4212:
URL: https://github.com/apache/maka/pull/4212
## Summary
Seventh surface under #3944 (one surface per PR): the **Agent Graph panel** (`AgentGraphPanel`, mounted in the conversation column when the active session runs in `graph` orchestration mode) had **no Storybook story at all**. This adds its failure and edge states in a new `apps/desktop/stories/agent-graph-panel.stories.tsx`.
The panel reads its snapshot from `window.maka.graphs` (IPC), not props or context, so each story installs a scoped bridge (`withScopedMakaBridge`) that serves one pinned `AgentGraphClientSnapshot`:
- **EmptyGraph** — graph mode enabled but no operator provisioned yet: the panel's own empty state.
- **FailedGraph** — a failed operator beside completed/running ones, graph status `failed`.
- **BlockedOnUpstream** — a blocked operator with the amber "waiting for input" readiness line.
- **ManyOperators** — a wide fan-out with the truncation "+N" line (`omitted.operators`).
- **LoadError** — the IPC snapshot read rejects: the panel's error Banner + Retry.
The panel renders operators as a **flat list** — it draws no edges or hierarchy — so tree depth and cycles have no distinct rendering and are left out rather than faked. All states are safe presentational renders; the read closure is wrapped, so a rejected read settles into the error banner without a console error (the one hard requirement — `subscribe` is called outside the try/catch — is met by installing the full `graphs` bridge).
Refs #3944, #3893
## Verification
- `apps/desktop` `typecheck:stories` passes; Biome lint and `git diff --check` clean.
- Storybook build + render smoke: **201 stories**, all green, no runtime/console/page errors, per-story AX-tree audit clean. The five new ids: `product-agent-graph--empty-graph`, `--failed-graph`, `--blocked-on-upstream`, `--many-operators`, `--load-error`.
- `play` runs under the smoke and proves each state renders: the empty-state copy, the `li[data-status="failed"]` row, the blocked row + `.maka-agent-graph-wait` line, the twelve visible rows + `.maka-agent-graph-omitted` truncation line, and the load-error banner copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): story-cover agent graph failure and edge states [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4212:
URL: https://github.com/apache/maka/pull/4212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org